RESOLVED FIXED 165819
[CSS Parser] Eliminate SVGPaint and SVGColor 
https://bugs.webkit.org/show_bug.cgi?id=165819
Summary [CSS Parser] Eliminate SVGPaint and SVGColor
Dave Hyatt
Reported 2016-12-13 13:08:16 PST
[CSS Parser] Eliminate SVGPaint and SVGColor
Attachments
Patch (143.03 KB, patch)
2016-12-13 13:14 PST, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-12-13 13:14:26 PST
Created attachment 297037 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-13 13:16:23 PST
Attachment 297037 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/rendering/style/SVGRenderStyleDefs.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 8 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2016-12-13 14:16:29 PST
Fixed in r209777. Removed the fill/stroke stuff in transitions/svg-transitions.html and patched DerivedSource.cpp for Windows build.
Note You need to log in before you can comment on or make changes to this bug.