Bug 165807 - Small refactor: Use HashCountedSet rather than HashMap<..., int> to store client counts in WebPlaybackSessionManager{,Proxy}.
Summary: Small refactor: Use HashCountedSet rather than HashMap<..., int> to store cli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-13 10:29 PST by Jer Noble
Modified: 2016-12-16 14:06 PST (History)
4 users (show)

See Also:

Attachments
Patch for landing (7.25 KB, patch)
2016-12-13 10:33 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (5.81 KB, patch)
2016-12-13 10:41 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-12-13 10:29:50 PST 
Small refactor: Use HashCountedSet rather than HashMap<..., int> to store client counts in WebPlaybackSessionManager{,Proxy}.
Comment 1 Jer Noble 2016-12-13 10:33:05 PST 
Created attachment 297021 [details]
Patch for landing
Comment 2 Jer Noble 2016-12-13 10:41:48 PST 
Created attachment 297024 [details]
Patch
Comment 3 Eric Carlson 2016-12-16 13:02:58 PST 
Comment on attachment 297024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297024&action=review

> Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:37
>  #include <wtf/HashSet.h>

Nit: you can probably delete this.
Comment 4 Jer Noble 2016-12-16 13:37:47 PST 
Comment on attachment 297024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297024&action=review

>> Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:37
>>  #include <wtf/HashSet.h>
> 
> Nit: you can probably delete this.

Unfortunately, there's another HashMap member and another HashSet member in this file.
Comment 5 WebKit Commit Bot 2016-12-16 14:06:32 PST 
Comment on attachment 297024 [details]
Patch

Clearing flags on attachment: 297024

Committed r209937: <http://trac.webkit.org/changeset/209937>
Comment 6 WebKit Commit Bot 2016-12-16 14:06:36 PST 
All reviewed patches have been landed.  Closing bug.