Bug 165802 - IndexedDB 2.0: Massively speedup IDBIndex.get()
Summary: IndexedDB 2.0: Massively speedup IDBIndex.get()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on: 165803
Blocks: 160306
  Show dependency tree / graph
 
Reported: 2016-12-13 09:53 PST by Brady Eidson
Modified: 2016-12-14 12:57 PST (History)
5 users (show)

See Also:

Attachments
Patch (41.26 KB, patch)
2016-12-14 11:41 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-12-13 09:53:45 PST 
IndexedDB 2.0: Don't use a cursor internally for IDBIndex.get()

I put together a perf test that benchmarks IDBIndex.get(), and using a cursor to do it was extremely hot in profiles.
Comment 1 Brady Eidson 2016-12-13 09:56:42 PST 
I'm going to try to land the test first and give the bots at least 1 cycle on it, so we have a record of the speedup.
Comment 2 Brady Eidson 2016-12-14 11:41:27 PST 
Created attachment 297107 [details]
Patch
Comment 3 Brady Eidson 2016-12-14 11:57:43 PST 
<rdar://problem/29666094>
Comment 4 WebKit Commit Bot 2016-12-14 12:57:26 PST 
Comment on attachment 297107 [details]
Patch

Clearing flags on attachment: 297107

Committed r209824: <http://trac.webkit.org/changeset/209824>
Comment 5 WebKit Commit Bot 2016-12-14 12:57:29 PST 
All reviewed patches have been landed.  Closing bug.