RESOLVED FIXED165797
REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs 
https://bugs.webkit.org/show_bug.cgi?id=165797
Summary REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
Michael Catanzaro
Reported 2016-12-13 08:09:47 PST
Source/WebKit is distributed in tarballs. In particular, there are a bunch of files under Source/WebKit/Storage. This isn't right, we shouldn't have Source/WebKit at all.
Attachments
Patch (1.96 KB, patch)
2017-01-02 06:39 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-01-02 06:32:43 PST
I think I messed it up in r173753 by adding a new rulset in the middle of the directory source ruleset. I have to admit I don't completely understand the manifest format. The thing is that we have this: directory Source/WebInspectorUI/UserInterface/Images/gtk # Most of the files in Source/WebKit are not necessary to build GTK+ and # the directory includes lots of images, so we're a bit more picky here. exclude Source/WebKit/.* That directory rule is adding a new ruleset, it should added after all the exclude, because the default is to include.
Carlos Garcia Campos
Comment 2 2017-01-02 06:39:53 PST
Created attachment 297896 [details] Patch
Carlos Garcia Campos
Comment 3 2017-01-03 00:16:09 PST
Committed r210233: <http://trac.webkit.org/changeset/210233>
Note You need to log in before you can comment on or make changes to this bug.