Bug 165797 - REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
Summary: REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-13 08:09 PST by Michael Catanzaro
Modified: 2017-01-03 00:16 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2017-01-02 06:39 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-12-13 08:09:47 PST 
Source/WebKit is distributed in tarballs. In particular, there are a bunch of files under Source/WebKit/Storage. This isn't right, we shouldn't have Source/WebKit at all.
Comment 1 Carlos Garcia Campos 2017-01-02 06:32:43 PST 
I think I messed it up in r173753 by adding a new rulset in the middle of the directory source ruleset. I have to admit I don't completely understand the manifest format. The thing is that we have this:

directory Source/WebInspectorUI/UserInterface/Images/gtk

# Most of the files in Source/WebKit are not necessary to build GTK+ and
# the directory includes lots of images, so we're a bit more picky here.
exclude Source/WebKit/.*

That directory rule is adding a new ruleset, it should added after all the exclude, because the default is to include.
Comment 2 Carlos Garcia Campos 2017-01-02 06:39:53 PST 
Created attachment 297896 [details]
Patch
Comment 3 Carlos Garcia Campos 2017-01-03 00:16:09 PST 
Committed r210233: <http://trac.webkit.org/changeset/210233>