Bug 165796 – text-align: justify and word-spacing combine to overflow column

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Brad West]

Created attachment 297005 [details]
HTML with inline CSS demonstrating problem

When text-align: justify is used in combination with word-spacing, the text will almost always overflows a column (horizontally). In attached HTML, an exaggerated value of 20px is used for word-spacing, but the problem also occurs with smaller, more reasonable values. 

Of note is the fifth line (ending in "post-ironic.") that, for whatever reason, does not overflow.

Curiously, the amount that it overflows seems to be the exact value used for word-spacing. Hopefully that suggests something about the nature of the bug. 

It also means that for most lines, one could work around the issue by specifying a padding-right value with the same value as word-spacing. Unfortunately, though, the lines that work above ("post-ironic") become too far inset.

[Brad West]

Created attachment 297006 [details]
Text overflows bounds of p when justify and word-spacing both used

[Brad West]

Created attachment 297007 [details]
Text behaves as expected when only justify is used

[Brad West]

Created attachment 297008 [details]
Text also behaves if only word-spacing is used

[Brad West]

Created attachment 297009 [details]
Workaround with padding-right, successful except for "post-ironic" line

[zalan]

*** Bug 165873 has been marked as a duplicate of this bug. ***

[zalan]

rdar://problem/29672168

[zalan]

Created attachment 297165 [details]
Patch

[zalan]

Created attachment 297166 [details]
Patch

[Build Bot]

Comment on attachment 297166 [details]
Patch

Attachment 297166 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2726869

New failing tests:
fast/text/whitespace/span-in-word-space-causes-overflow.html
css1/text_properties/word_spacing.html

[Build Bot]

Created attachment 297184 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[zalan]

Created attachment 297192 [details]
Patch

[zalan]

Comment on attachment 297184 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

Some iOS rebaseline.

[Myles C. Maxfield]

Comment on attachment 297192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297192&action=review

> LayoutTests/fast/css/word-spacing-with-normal-layout.html:18
> +if (window.internals)
> +	internals.settings.setSimpleLineLayoutDebugBordersEnabled(false);

Why is this here?

[zalan]

(In reply to comment #13)
> Comment on attachment 297192 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297192&action=review
> 
> > LayoutTests/fast/css/word-spacing-with-normal-layout.html:18
> > +if (window.internals)
> > +	internals.settings.setSimpleLineLayoutDebugBordersEnabled(false);
> 
> Why is this here?
lol, good catch. It was meant to read setSimpleLineLayoutEnabled.

[zalan]

Created attachment 297291 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 297291 [details]
Patch

Clearing flags on attachment: 297291

Committed r209910: <http://trac.webkit.org/changeset/209910>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.