RESOLVED FIXED165789
Change ::computeLogicalHeight's computedValues out argument to the return value. 
https://bugs.webkit.org/show_bug.cgi?id=165789
Summary Change ::computeLogicalHeight's computedValues out argument to the return value.
alan
Reported 2016-12-12 20:23:32 PST
as suggested it in here https://bugs.webkit.org/show_bug.cgi?id=164891#c7
Attachments
Patch (36.99 KB, patch)
2016-12-12 20:55 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (36.90 KB, patch)
2016-12-15 20:00 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-12-12 20:55:42 PST
Created attachment 296989 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-12-15 14:14:22 PST
Comment on attachment 296989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296989&action=review > Source/WebCore/rendering/RenderBlock.cpp:2797 > + childMinPreferredLogicalWidth = childMaxPreferredLogicalWidth = childBox.computeLogicalHeight( > + childBox.borderAndPaddingLogicalHeight(), 0).m_extent; No need to wrap.
alan
Comment 3 2016-12-15 20:00:39 PST
Created attachment 297292 [details] Patch
WebKit Commit Bot
Comment 4 2016-12-15 20:38:05 PST
Comment on attachment 297292 [details] Patch Clearing flags on attachment: 297292 Committed r209903: <http://trac.webkit.org/changeset/209903>
WebKit Commit Bot
Comment 5 2016-12-15 20:38:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.