Bug 165789 - Change ::computeLogicalHeight's computedValues out argument to the return value.
Summary: Change ::computeLogicalHeight's computedValues out argument to the return value.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 20:23 PST by zalan
Modified: 2016-12-15 20:38 PST (History)
2 users (show)

See Also:

Attachments
Patch (36.99 KB, patch)
2016-12-12 20:55 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (36.90 KB, patch)
2016-12-15 20:00 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-12-12 20:23:32 PST 
as suggested it in here https://bugs.webkit.org/show_bug.cgi?id=164891#c7
Comment 1 zalan 2016-12-12 20:55:42 PST 
Created attachment 296989 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-12-15 14:14:22 PST 
Comment on attachment 296989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296989&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2797
> +            childMinPreferredLogicalWidth = childMaxPreferredLogicalWidth = childBox.computeLogicalHeight(
> +                childBox.borderAndPaddingLogicalHeight(), 0).m_extent;

No need to wrap.
Comment 3 zalan 2016-12-15 20:00:39 PST 
Created attachment 297292 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-15 20:38:05 PST 
Comment on attachment 297292 [details]
Patch

Clearing flags on attachment: 297292

Committed r209903: <http://trac.webkit.org/changeset/209903>
Comment 5 WebKit Commit Bot 2016-12-15 20:38:10 PST 
All reviewed patches have been landed.  Closing bug.