Bug 165787 - [WebIDL] Remove use of Dictionary in ApplePaySession
Summary: [WebIDL] Remove use of Dictionary in ApplePaySession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-12 18:41 PST by Sam Weinig
Modified: 2017-03-14 15:41 PDT (History)
8 users (show)

See Also:

Attachments
Patch (118.28 KB, patch)
2016-12-12 18:55 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (955.74 KB, application/zip)
2016-12-12 20:02 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (953.66 KB, application/zip)
2016-12-12 20:06 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.68 MB, application/zip)
2016-12-12 20:08 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (deleted)
2016-12-12 20:27 PST, Build Bot 		no flags Details
Patch (119.64 KB, patch)
2016-12-13 10:03 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-12-12 18:41:19 PST 
[WebIDL] Remove use of Dictionary in ApplePaySession
Comment 1 Sam Weinig 2016-12-12 18:55:01 PST 
Created attachment 296979 [details]
Patch
Comment 2 Sam Weinig 2016-12-12 18:55:39 PST 
I probably need to disable the new test directory on platforms that don't support ApplePay.
Comment 3 WebKit Commit Bot 2016-12-12 18:57:09 PST 
Attachment 296979 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:176:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2016-12-12 20:02:54 PST 
Comment on attachment 296979 [details]
Patch

Attachment 296979 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2709520

New failing tests:
http/tests/ssl/applepay/ApplePaySession.html
Comment 5 Build Bot 2016-12-12 20:02:58 PST 
Created attachment 296985 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-12-12 20:06:52 PST 
Comment on attachment 296979 [details]
Patch

Attachment 296979 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2709531

New failing tests:
http/tests/ssl/applepay/ApplePaySession.html
Comment 7 Build Bot 2016-12-12 20:06:57 PST 
Created attachment 296986 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-12-12 20:08:40 PST 
Comment on attachment 296979 [details]
Patch

Attachment 296979 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2709516

New failing tests:
http/tests/ssl/applepay/ApplePaySession.html
Comment 9 Build Bot 2016-12-12 20:08:44 PST 
Created attachment 296987 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-12-12 20:27:29 PST 
Comment on attachment 296979 [details]
Patch

Attachment 296979 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2709557

New failing tests:
http/tests/ssl/applepay/ApplePaySession.html
Comment 11 Build Bot 2016-12-12 20:27:34 PST 
Created attachment 296988 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 12 Sam Weinig 2016-12-13 10:03:14 PST 
Created attachment 297018 [details]
Patch
Comment 13 WebKit Commit Bot 2016-12-13 10:06:15 PST 
Attachment 297018 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:176:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Anders Carlsson 2016-12-13 10:22:26 PST 
Comment on attachment 297018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297018&action=review

> Source/WebCore/Modules/applepay/ApplePaySession.cpp:300
> +    // FIXME: Should this swallow exceptions like the old code seemed to do?

I don't think so!
Comment 15 Sam Weinig 2016-12-13 10:47:34 PST 
Committed r209760: <http://trac.webkit.org/changeset/209760>
Comment 16 Radar WebKit Bug Importer 2017-03-03 10:30:00 PST 
<rdar://problem/30835075>