Bug 165787 – [WebIDL] Remove use of Dictionary in ApplePaySession

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Remove use of Dictionary in ApplePaySession

[Sam Weinig]

Created attachment 296979 [details]
Patch

[Sam Weinig]

I probably need to disable the new test directory on platforms that don't support ApplePay.

[WebKit Commit Bot]

Attachment 296979 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:176:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296979 [details]
Patch

Attachment 296979 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2709520

New failing tests:
http/tests/ssl/applepay/ApplePaySession.html

[Build Bot]

Created attachment 296985 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296979 [details]
Patch

Attachment 296979 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2709531

New failing tests:
http/tests/ssl/applepay/ApplePaySession.html

[Build Bot]

Created attachment 296986 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296979 [details]
Patch

Attachment 296979 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2709516

New failing tests:
http/tests/ssl/applepay/ApplePaySession.html

[Build Bot]

Created attachment 296987 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296979 [details]
Patch

Attachment 296979 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2709557

New failing tests:
http/tests/ssl/applepay/ApplePaySession.html

[Build Bot]

Created attachment 296988 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 297018 [details]
Patch

[WebKit Commit Bot]

Attachment 297018 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:176:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 297018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297018&action=review

> Source/WebCore/Modules/applepay/ApplePaySession.cpp:300
> +    // FIXME: Should this swallow exceptions like the old code seemed to do?

I don't think so!

[Sam Weinig]

Committed r209760: <http://trac.webkit.org/changeset/209760>

[Radar WebKit Bug Importer]

<rdar://problem/30835075>