Bug 165785 - [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
Summary: [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-12 17:11 PST by Andy Estes
Modified: 2016-12-13 14:09 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.06 KB, patch)
2016-12-12 17:37 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (14.97 KB, patch)
2016-12-12 17:48 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (15.25 KB, patch)
2016-12-13 11:30 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-12-12 17:11:09 PST 
[Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
Comment 1 Andy Estes 2016-12-12 17:37:03 PST 
Created attachment 296973 [details]
Patch
Comment 2 Andy Estes 2016-12-12 17:37:53 PST 
rdar://problem/26929398
Comment 3 WebKit Commit Bot 2016-12-12 17:39:17 PST 
Attachment 296973 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:589:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:640:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andy Estes 2016-12-12 17:48:19 PST 
Created attachment 296974 [details]
Patch
Comment 5 WebKit Commit Bot 2016-12-12 17:50:08 PST 
Attachment 296974 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:590:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:641:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Darin Adler 2016-12-12 20:22:04 PST 
Comment on attachment 296974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296974&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:605
> +            WKEditorInsertAction wkAction;
> +            switch (action) {
> +            case EditorInsertActionTyped:
> +                wkAction = WKEditorInsertActionTyped;
> +                break;
> +            case EditorInsertActionPasted:
> +                wkAction = WKEditorInsertActionPasted;
> +                break;
> +            case EditorInsertActionDropped:
> +                wkAction = WKEditorInsertActionDropped;
> +                break;
> +            }

Would like this mapping to be a separate helper function.
Comment 7 Andy Estes 2016-12-13 11:30:49 PST 
Created attachment 297027 [details]
Patch
Comment 8 WebKit Commit Bot 2016-12-13 14:09:23 PST 
Comment on attachment 297027 [details]
Patch

Clearing flags on attachment: 297027

Committed r209775: <http://trac.webkit.org/changeset/209775>
Comment 9 WebKit Commit Bot 2016-12-13 14:09:28 PST 
All reviewed patches have been landed.  Closing bug.