Bug 165784 - Add Document.onvisibilitychange event handler attribute
Summary: Add Document.onvisibilitychange event handler attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://w3c.github.io/page-visibility/...
Keywords: WebExposed
: 174177 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-12 16:48 PST by Chris Dumez
Modified: 2017-07-07 13:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.43 KB, patch)
2016-12-12 16:50 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.43 KB, patch)
2016-12-12 17:29 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-12-12 16:48:26 PST 
Add Document.onvisibilitychange event handler attribute as per Page Visibility Level 2 API:
- http://w3c.github.io/page-visibility/#onvisiblitychange-event-handler
Comment 1 Chris Dumez 2016-12-12 16:50:07 PST 
Created attachment 296968 [details]
Patch
Comment 2 Daniel Bates 2016-12-12 17:18:18 PST 
Comment on attachment 296968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296968&action=review

> LayoutTests/fast/events/page-visibility-onvisibilitychange.html:1
> +<html>

Please add <!DOCTYPE html> to the top of this file as I do not see the need to use quirks mode for this test.

> LayoutTests/fast/events/page-visibility-onvisibilitychange.html:2
> +<body onload='startTest()'>

We are underutilizing the purpose of the onload attribute given that the startTest() is defined in a script inside <body>. I suggest that we call startTest() above </script> and then remove the onload attribute from this line.
Comment 3 Chris Dumez 2016-12-12 17:29:32 PST 
Created attachment 296971 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-12 18:06:16 PST 
Comment on attachment 296971 [details]
Patch

Clearing flags on attachment: 296971

Committed r209750: <http://trac.webkit.org/changeset/209750>
Comment 5 WebKit Commit Bot 2016-12-12 18:06:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2017-07-07 13:33:07 PDT 
*** Bug 174177 has been marked as a duplicate of this bug. ***