WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
165784
Add Document.onvisibilitychange event handler attribute
https://bugs.webkit.org/show_bug.cgi?id=165784
Summary
Add Document.onvisibilitychange event handler attribute
Chris Dumez
Reported
2016-12-12 16:48:26 PST
Add Document.onvisibilitychange event handler attribute as per Page Visibility Level 2 API: -
http://w3c.github.io/page-visibility/#onvisiblitychange-event-handler
Attachments
Patch
(4.43 KB, patch)
2016-12-12 16:50 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(4.43 KB, patch)
2016-12-12 17:29 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2016-12-12 16:50:07 PST
Created
attachment 296968
[details]
Patch
Daniel Bates
Comment 2
2016-12-12 17:18:18 PST
Comment on
attachment 296968
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=296968&action=review
> LayoutTests/fast/events/page-visibility-onvisibilitychange.html:1 > +<html>
Please add <!DOCTYPE html> to the top of this file as I do not see the need to use quirks mode for this test.
> LayoutTests/fast/events/page-visibility-onvisibilitychange.html:2 > +<body onload='startTest()'>
We are underutilizing the purpose of the onload attribute given that the startTest() is defined in a script inside <body>. I suggest that we call startTest() above </script> and then remove the onload attribute from this line.
Chris Dumez
Comment 3
2016-12-12 17:29:32 PST
Created
attachment 296971
[details]
Patch
WebKit Commit Bot
Comment 4
2016-12-12 18:06:16 PST
Comment on
attachment 296971
[details]
Patch Clearing flags on attachment: 296971 Committed
r209750
: <
http://trac.webkit.org/changeset/209750
>
WebKit Commit Bot
Comment 5
2016-12-12 18:06:20 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 6
2017-07-07 13:33:07 PDT
***
Bug 174177
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug