NEW165781
Merge m_setNeedsLayoutWasDeferred with the viewport unit resolving infinite recursion logic. 
https://bugs.webkit.org/show_bug.cgi?id=165781
Summary Merge m_setNeedsLayoutWasDeferred with the viewport unit resolving infinite r...
alan
Reported 2016-12-12 15:55:02 PST
bug 165775 and even better, use the layout phase (adjustViewSize) instead of the deferred flag.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2024-02-29 15:27:58 PST
Blink removed this code in this commit - https://chromium.googlesource.com/chromium/blink/+/f9b0d34b5bac00f3dedaa44b360590ba3ad55ad8 "This code was added in https://trac.webkit.org/changeset/43026 5 years ago without a test for a bug with how Mail embedded WebKit1. We've long since moved past that and it doesn't seem it should be needed anymore, and the code was never finished either."
Ahmad Saleem
Comment 2 2024-03-03 18:01:18 PST
@Karl - does Mail uses WebKit1 (WebKit Legacy) still now? Appreciate if you can share input?
Karl Dubost
Comment 3 2024-03-03 18:16:21 PST
@Ahmad, I don't know! Maybe a question worth asking on #webkit Slack. :)
alan
Comment 4 2024-03-03 19:40:28 PST
(In reply to Ahmad Saleem from comment #2) > @Karl - does Mail uses WebKit1 (WebKit Legacy) still now? Appreciate if you > can share input? It does not.
Ahmad Saleem
Comment 5 2024-03-04 15:16:29 PST
Draft PR to delete 'deferred setNeedsLayout' - https://github.com/WebKit/WebKit/pull/25458 Let's see - if we still need it or not via EWS. :-)
Ahmad Saleem
Comment 6 2024-04-09 01:58:37 PDT
This leads to crashes in few tests without much details: Mac-wk1 failures: editing/selection/move-by-line-crash.html - no crash logs from EWS fast/flexbox/flex-hang.html - rebase (1 px shift) fast/repaint/border-radius-repaint-2.html - simple rebase Mac-wk2-debug failures: compositing/fixed-with-fixed-layout.html, fast/fixed-layout/fixed-layout.html Both with same assert failure: No crash log found for com.apple.WebKit.WebContent.Development:1234. stdout: stderr: ASSERTION FAILED: !layoutRoot->needsLayout() /Volumes/Data/worker/macOS-AppleSilicon-Sonoma-Debug-Build-EWS/build/Source/WebCore/page/LocalFrameViewLayoutContext.cpp(269) : void WebCore::LocalFrameViewLayoutContext::performLayout() com.apple.WebKit.WebContent.Development terminated (pid 1234) for reason: crash LEAK: 1 WebPageProxy This assert was added by Alan in this commit: https://github.com/WebKit/WebKit/commit/8421bc7ac25b99f393f654a8dd4ca49671fe7f59
Note You need to log in before you can comment on or make changes to this bug.