Bug 165778 - Drop unnecessary null check in removeDetachedChildrenInContainer()
Summary: Drop unnecessary null check in removeDetachedChildrenInContainer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 15:03 PST by Chris Dumez
Modified: 2016-12-13 20:56 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2016-12-12 15:04 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Attempt to fix OpenSource iOS builds (63.12 KB, text/plain)
2016-12-13 20:55 PST, Wenson Hsieh
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-12-12 15:03:53 PST
Drop unnecessary null check in removeDetachedChildrenInContainer(). Node cannot be null but we do an implicit null check.
Comment 1 Chris Dumez 2016-12-12 15:04:59 PST
Created attachment 296955 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-12 18:21:31 PST
Comment on attachment 296955 [details]
Patch

Clearing flags on attachment: 296955

Committed r209751: <http://trac.webkit.org/changeset/209751>
Comment 3 WebKit Commit Bot 2016-12-12 18:21:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Wenson Hsieh 2016-12-13 20:55:03 PST
Reopening to attach new patch.
Comment 5 Wenson Hsieh 2016-12-13 20:55:06 PST
Created attachment 297063 [details]
Attempt to fix OpenSource iOS builds
Comment 6 Wenson Hsieh 2016-12-13 20:55:59 PST
My bad, accidentally reopened this when uploading a patch :/ Closing again.