Bug 165771 - [CSS Parser] MediaQueryParser should use Ref and not RefPtr
Summary: [CSS Parser] MediaQueryParser should use Ref and not RefPtr
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 13:10 PST by Dave Hyatt
Modified: 2023-05-02 13:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.18 KB, patch)
2016-12-12 13:11 PST, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-12-12 13:10:59 PST 
[CSS Parser] MediaQueryParser should use Ref and not RefPtr
Comment 1 Dave Hyatt 2016-12-12 13:11:58 PST 
Created attachment 296946 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-12 13:13:49 PST 
Attachment 296946 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/MediaQueryParser.h:92:  'parseInternal' is incorrectly named. It should be named 'protector' or 'protectedCSSParserTokenRange'.  [readability/naming/protected] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2016-12-12 13:50:35 PST 
Fixed in r209726.
Comment 4 Gavin Barraclough 2016-12-14 00:26:01 PST 
Rolled out in r209794 due to memory regression in r209726.
Comment 5 Tim Nguyen (:ntim) 2023-05-02 13:14:44 PDT 
The media query code has since been rewritten