RESOLVED FIXED 165752
Web Inspector: Allow keyboard navigation in Heap Snapshot data grids 
https://bugs.webkit.org/show_bug.cgi?id=165752
Summary Web Inspector: Allow keyboard navigation in Heap Snapshot data grids
Matt Baker
Reported 2016-12-12 03:00:49 PST
Summary: Allow keyboard navigation in Heap Snapshot data grids. Rows in the Object Graph view can't be selected, and in the Instances view only top-level nodes are selectable and keyboard navigable. The only obstacle is aesthetic: colored object preview and string literal text looks poor against a the highlight background color (blue).
Attachments
[Image] Seleted row w/ object preview (462.79 KB, image/png)
2016-12-12 03:12 PST, Matt Baker 		no flags
Details
[Image] selected row w/ object ID and count (428.13 KB, image/png)
2016-12-12 03:13 PST, Matt Baker 		no flags
Details
[Image] Better sub retained text color (463.15 KB, image/png)
2016-12-12 03:31 PST, Matt Baker 		no flags
Details
Patch (5.01 KB, patch)
2016-12-12 03:35 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2016-12-12 03:02:11 PST
rdar://problem/28784315
Matt Baker
Comment 2 2016-12-12 03:12:31 PST
Created attachment 296907 [details] [Image] Seleted row w/ object preview
Matt Baker
Comment 3 2016-12-12 03:13:03 PST
Created attachment 296908 [details] [Image] selected row w/ object ID and count
Matt Baker
Comment 4 2016-12-12 03:31:27 PST
Created attachment 296909 [details] [Image] Better sub retained text color
Matt Baker
Comment 5 2016-12-12 03:35:47 PST
Created attachment 296910 [details] Patch
Blaze Burg
Comment 6 2016-12-12 09:16:50 PST
Comment on attachment 296910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296910&action=review r=me > Source/WebInspectorUI/ChangeLog:26 > + Removed forced-focus reference. Only used by TreeOutlineDataGridSynchronizer. nit: 'force-focus'
WebKit Commit Bot
Comment 7 2016-12-12 09:21:10 PST
Comment on attachment 296910 [details] Patch Clearing flags on attachment: 296910 Committed r209709: <http://trac.webkit.org/changeset/209709>
WebKit Commit Bot
Comment 8 2016-12-12 09:21:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.