Bug 165744 - Web Inspector: content views are not restored on reload if its tree element is filtered out
Summary: Web Inspector: content views are not restored on reload if its tree element i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-11 16:05 PST by BJ Burg
Modified: 2017-05-23 18:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.77 KB, patch)
2017-05-03 16:46 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-12-11 16:05:56 PST 
STEPS TO REPRODUCE:

1. Go to a website
2. Open Resources Tab
3. Select some resource tree element
4. Enter some jibberish into "Filter Resource List" at the bottom of the sidebar
5. Reload
=> Content view is restored as expected despite no tree element visible
6. Reload
=> Content view is not restored, shows the main resource

My hunch is that we are unable to correctly serialize the current content view / represented object the second time because its corresponding tree element was never created. State restoration code is based on the selected tree element, so if nothing is selected then we won't restore anything either.
Comment 1 BJ Burg 2016-12-11 16:07:16 PST 
<rdar://problem/27461323>
Comment 2 Matt Baker 2017-05-03 16:46:30 PDT 
Created attachment 308985 [details]
Patch
Comment 3 Devin Rousso 2017-05-23 17:09:05 PDT 
Comment on attachment 308985 [details]
Patch

r=me
Comment 4 Matt Baker 2017-05-23 17:41:41 PDT 
You can cq+ at the same time, if you don't have any feedback that needs to be addressed.
Comment 5 WebKit Commit Bot 2017-05-23 18:09:22 PDT 
Comment on attachment 308985 [details]
Patch

Clearing flags on attachment: 308985

Committed r217317: <http://trac.webkit.org/changeset/217317>
Comment 6 WebKit Commit Bot 2017-05-23 18:09:24 PDT 
All reviewed patches have been landed.  Closing bug.