RESOLVED FIXED165722
Replace isUnclosedNode by isClosedShadowHidden 
https://bugs.webkit.org/show_bug.cgi?id=165722
Summary Replace isUnclosedNode by isClosedShadowHidden
Ryosuke Niwa
Reported 2016-12-10 00:09:44 PST
The DOM Specification recently replaced the concept of “unclosed” by “closed-shadow-hidden” (negated). https://dom.spec.whatwg.org/#concept-closed-shadow-hidden https://github.com/whatwg/dom/pull/306 The new name is pretty horrible but there’s still a value in matching the spec terminology so do that.
Attachments
Refactors the code (5.61 KB, patch)
2016-12-10 00:13 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-12-10 00:13:59 PST
Created attachment 296786 [details] Refactors the code
Antti Koivisto
Comment 2 2016-12-10 02:07:37 PST
Comment on attachment 296786 [details] Refactors the code View in context: https://bugs.webkit.org/attachment.cgi?id=296786&action=review > Source/WebCore/dom/Node.cpp:1078 > +static bool isClosedShadowHiddenUsingSpecDefinition(const Node& A, const Node& B) "Specification"
WebKit Commit Bot
Comment 3 2016-12-10 02:19:30 PST
Comment on attachment 296786 [details] Refactors the code Clearing flags on attachment: 296786 Committed r209661: <http://trac.webkit.org/changeset/209661>
WebKit Commit Bot
Comment 4 2016-12-10 02:19:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.