Bug 165715 – WebAssembly: implement the elements section

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Will work on this now.

[Saam Barati]

Created attachment 297041 [details]
WIP

it begins

[Saam Barati]

Created attachment 297045 [details]
WIP

This might be the patch. Need to start writing tests.

[Saam Barati]

Created attachment 297047 [details]
patch

[WebKit Commit Bot]

Attachment 297047 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WasmModuleParser.cpp:509:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keith Miller]

Comment on attachment 297047 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297047&action=review

r=me.

> Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:229
> +                return throwException(state, scope, createRangeError(state,
> +                    ASCIILiteral("Element is trying to set an out of bounds table index")));

Why not just throwVMRangeError()? Unless you want to build a string with the indices seems like we should just use the simpler syntax.

> Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:239
> +                        ASCIILiteral("Element is setting the table value with an import. This is not yet implemented. FIXME:")));

Did you mean to link to a bug here?

[Saam Barati]

Comment on attachment 297047 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297047&action=review

>> Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:229
>> +                    ASCIILiteral("Element is trying to set an out of bounds table index")));
> 
> Why not just throwVMRangeError()? Unless you want to build a string with the indices seems like we should just use the simpler syntax.

Yeah sounds good.

>> Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:239
>> +                        ASCIILiteral("Element is setting the table value with an import. This is not yet implemented. FIXME:")));
> 
> Did you mean to link to a bug here?

Yeah. I'll do that.

[Saam Barati]

landed in:
https://trac.webkit.org/changeset/209785