Bug 165701 - Web Inspector: Move MainTarget and WorkerTarget to their own files
Summary: Web Inspector: Move MainTarget and WorkerTarget to their own files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-12-09 16:22 PST by Joseph Pecoraro
Modified: 2016-12-11 15:37 PST (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (14.29 KB, patch)
2016-12-09 16:27 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-12-09 16:22:59 PST 
Summary:
Move MainTarget and WorkerTarget to their own files

This is cleanup that I had in another patch that is stalled. Separating it out into its own patch.
Comment 1 Joseph Pecoraro 2016-12-09 16:27:14 PST 
Created attachment 296737 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2016-12-11 15:12:30 PST 
Comment on attachment 296737 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=296737&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Protocol/Target.js:-147
> -    initialize()

Why did this construction ever exist instead of putting in just one subclass constructor?
Comment 3 WebKit Commit Bot 2016-12-11 15:37:43 PST 
Comment on attachment 296737 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 296737

Committed r209686: <http://trac.webkit.org/changeset/209686>
Comment 4 WebKit Commit Bot 2016-12-11 15:37:48 PST 
All reviewed patches have been landed.  Closing bug.