Bug 165688 - Web Inspector: Cleanup some InspectorInstrumentation network loading notifications
Summary: Web Inspector: Cleanup some InspectorInstrumentation network loading notifica...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-12-09 14:48 PST by Joseph Pecoraro
Modified: 2016-12-11 15:40 PST (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (18.83 KB, patch)
2016-12-09 16:11 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-12-09 14:48:32 PST 
Summary:
Cleanup some InspectorInstrumentation network loading notifications

There is a lot of code that does:

    InspectorInstrumentationCookie cookie = InspectorInstrumentation::willReceiveResourceResponse(&m_frame);
    InspectorInstrumentation::didReceiveResourceResponse(cookie, identifier, loader, r, resourceLoader);

In which case the will* call that produces a cookie is entirely unnecessary.

Simplify this code and related code.
Comment 1 Joseph Pecoraro 2016-12-09 16:11:46 PST 
Created attachment 296732 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2016-12-11 15:14:41 PST 
Comment on attachment 296732 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2016-12-11 15:40:48 PST 
Comment on attachment 296732 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 296732

Committed r209687: <http://trac.webkit.org/changeset/209687>
Comment 4 WebKit Commit Bot 2016-12-11 15:40:54 PST 
All reviewed patches have been landed.  Closing bug.