RESOLVED FIXED 165687
Deploy OrdinalNumber in JSC::SourceCode 
https://bugs.webkit.org/show_bug.cgi?id=165687
Summary Deploy OrdinalNumber in JSC::SourceCode
Geoffrey Garen
Reported 2016-12-09 14:41:03 PST
Deploy OrdinalNumber in JSC::SourceCode
Attachments
Patch (16.99 KB, patch)
2016-12-09 14:43 PST, Geoffrey Garen 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-12-09 14:43:03 PST
Created attachment 296703 [details] Patch
Michael Saboff
Comment 2 2016-12-09 14:50:28 PST
Comment on attachment 296703 [details] Patch r=me
Saam Barati
Comment 3 2016-12-09 14:53:46 PST
Comment on attachment 296703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296703&action=review > Source/JavaScriptCore/parser/SourceCode.h:40 > + , m_firstLine(OrdinalNumber::beforeFirst()) > + , m_startColumn(OrdinalNumber::beforeFirst()) Is this just to indicate that this value doesn't mean anything? Why not just have a default empty constructor that does that?
Geoffrey Garen
Comment 4 2016-12-09 14:58:27 PST
> > Source/JavaScriptCore/parser/SourceCode.h:40 > > + , m_firstLine(OrdinalNumber::beforeFirst()) > > + , m_startColumn(OrdinalNumber::beforeFirst()) > > Is this just to indicate that this value doesn't mean anything? Why not just > have a default empty constructor that does that? The empty constructor constructs zero. Just like int() or unsigned() would. Eventually, we'll switch off of beforeFirst() and just have clients use std::optional.
Geoffrey Garen
Comment 5 2016-12-09 15:00:21 PST
Committed r209632: <http://trac.webkit.org/changeset/209632>
Note You need to log in before you can comment on or make changes to this bug.