Bug 165687 - Deploy OrdinalNumber in JSC::SourceCode
Summary: Deploy OrdinalNumber in JSC::SourceCode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 14:41 PST by Geoffrey Garen
Modified: 2016-12-09 15:00 PST (History)
9 users (show)

See Also:

Attachments
Patch (16.99 KB, patch)
2016-12-09 14:43 PST, Geoffrey Garen 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-12-09 14:41:03 PST 
Deploy OrdinalNumber in JSC::SourceCode
Comment 1 Geoffrey Garen 2016-12-09 14:43:03 PST 
Created attachment 296703 [details]
Patch
Comment 2 Michael Saboff 2016-12-09 14:50:28 PST 
Comment on attachment 296703 [details]
Patch

r=me
Comment 3 Saam Barati 2016-12-09 14:53:46 PST 
Comment on attachment 296703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296703&action=review

> Source/JavaScriptCore/parser/SourceCode.h:40
> +            , m_firstLine(OrdinalNumber::beforeFirst())
> +            , m_startColumn(OrdinalNumber::beforeFirst())

Is this just to indicate that this value doesn't mean anything? Why not just have a default empty constructor that does that?
Comment 4 Geoffrey Garen 2016-12-09 14:58:27 PST 
> > Source/JavaScriptCore/parser/SourceCode.h:40
> > +            , m_firstLine(OrdinalNumber::beforeFirst())
> > +            , m_startColumn(OrdinalNumber::beforeFirst())
> 
> Is this just to indicate that this value doesn't mean anything? Why not just
> have a default empty constructor that does that?

The empty constructor constructs zero. Just like int() or unsigned() would. Eventually, we'll switch off of beforeFirst() and just have clients use std::optional.
Comment 5 Geoffrey Garen 2016-12-09 15:00:21 PST 
Committed r209632: <http://trac.webkit.org/changeset/209632>