Bug 165685 - Ignore LayoutTests/imported/w3c/web-platform-tests/config.json
Summary: Ignore LayoutTests/imported/w3c/web-platform-tests/config.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 14:38 PST by Joseph Pecoraro
Modified: 2016-12-09 19:22 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.15 KB, patch)
2016-12-09 14:39 PST, Joseph Pecoraro 		rniwa: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (1.15 KB, patch)
2016-12-09 16:29 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-12-09 14:38:35 PST 
Ignore LayoutTests/imported/w3c/web-platform-tests/config.json

I get this file when I run:

    $ run-webkit-tests --debug LayoutTests/imported

It seems to include user specific data, for instance a path to my Build Directory:

    $ cat LayoutTests/imported/w3c/web-platform-tests/config.json | grep pecoraro
             "base_path": "/Users/pecoraro/Build/Debug/layout-test-results/_wpt_certs",

So it looks like it shouldn't be committed. I suggest ignoring it so it doesn't commonly show up as an untracked file.
Comment 1 Joseph Pecoraro 2016-12-09 14:39:21 PST 
Created attachment 296702 [details]
[PATCH] Proposed Fix
Comment 2 Ryosuke Niwa 2016-12-09 14:45:27 PST 
Comment on attachment 296702 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=296702&action=review

> LayoutTests/imported/w3c/web-platform-tests/.gitignore:1
> +config.json

We should probably do /config.json instead since we could have some other config.json in a subdirectory we want to check in.
Comment 3 Joseph Pecoraro 2016-12-09 16:29:39 PST 
Created attachment 296738 [details]
[PATCH] For Landing
Comment 4 WebKit Commit Bot 2016-12-09 19:07:31 PST 
Comment on attachment 296738 [details]
[PATCH] For Landing

Clearing flags on attachment: 296738

Committed r209645: <http://trac.webkit.org/changeset/209645>