Bug 165683 – Web Inspector: Add tests for Fetch API Network Data (CORs, Opaque Responses, Filtered Headers)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Add tests for Fetch API Network Data (CORs, Opaque Responses, Filtered Headers)

Fetch API has many modes, and can filter data from the JavaScript exposed Response data. However Web Inspector should always be able to see complete information about the Network requests.

This should already be the case, but we should add tests to verify that and make sure it doesn't regress!

[Joseph Pecoraro]

Created attachment 296769 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 296769 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=296769&action=review

r=me

> LayoutTests/http/tests/inspector/network/fetch-network-data.html:47
> +            InspectorTest.expectEqual(resource.responseHeaders["X-Custom-Header"], "Custom-Header-Value", "Should be able to see X-Custom-Header.");

This is pretty sweet.

> LayoutTests/http/tests/inspector/network/fetch-network-data.html:62
> +        name: "Network.Fetch.ModeCORs.SameOrigin",

Nit: it should always be 'CORS' as it is an acronym, unless it's 'cors' as in the literal value.

> LayoutTests/http/tests/inspector/network/fetch-network-data.html:100
> +                fetch("http://localhost:8000/inspector/network/resources/cors-data.pl", {mode: "same-origin"}).then(

Neat. Maybe we should start using this in inspector & tests for loading files, instead of XHR?

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/209734>