Bug 165678 - TextPosition and OrdinalNumber should be more like idiomatic numbers
Summary: TextPosition and OrdinalNumber should be more like idiomatic numbers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 13:36 PST by Geoffrey Garen
Modified: 2016-12-09 14:04 PST (History)
0 users

See Also:

Attachments
Patch (22.80 KB, patch)
2016-12-09 13:41 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (23.71 KB, patch)
2016-12-09 13:57 PST, Geoffrey Garen 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-12-09 13:36:01 PST 
TextPosition and OrdinalNumber should be more like idiomatic numbers
Comment 1 Geoffrey Garen 2016-12-09 13:41:38 PST 
Created attachment 296689 [details]
Patch
Comment 2 Mark Lam 2016-12-09 13:55:05 PST 
Comment on attachment 296689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296689&action=review

> Source/WebCore/xml/XMLErrors.cpp:63
> +    if (type == fatal || (m_errorCount < maxErrors && !(m_lastErrorPosition || (m_lastErrorPosition->m_line != position.m_line && m_lastErrorPosition->m_column != position.m_column)))) {

Shouldn't this be (!m_lastErrorPosition || (m_lastErrorPosition->... ?
Comment 3 Geoffrey Garen 2016-12-09 13:56:10 PST 
> > Source/WebCore/xml/XMLErrors.cpp:63
> > +    if (type == fatal || (m_errorCount < maxErrors && !(m_lastErrorPosition || (m_lastErrorPosition->m_line != position.m_line && m_lastErrorPosition->m_column != position.m_column)))) {
> 
> Shouldn't this be (!m_lastErrorPosition || (m_lastErrorPosition->... ?

Oops! Yup.
Comment 4 Geoffrey Garen 2016-12-09 13:57:17 PST 
Created attachment 296693 [details]
Patch
Comment 5 Geoffrey Garen 2016-12-09 14:04:43 PST 
Committed r209627: <http://trac.webkit.org/changeset/209627>