Bug 165673 - Password fields should not show the emoji button in TouchBar
Summary: Password fields should not show the emoji button in TouchBar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 12:34 PST by Beth Dakin
Modified: 2016-12-09 14:01 PST (History)
5 users (show)

See Also:

Attachments
Patch (17.75 KB, patch)
2016-12-09 12:51 PST, Beth Dakin 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-12-09 12:34:45 PST 
Passsword fields should not show the emoji button in TouchBar

rdar://problem/29235739
Comment 1 Beth Dakin 2016-12-09 12:51:19 PST 
Created attachment 296679 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-09 12:53:08 PST 
Attachment 296679 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1100:  Extra space in capture list.  [whitespace/brackets] [4]
ERROR: Source/WebKit/mac/WebView/WebView.mm:9546:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Wenson Hsieh 2016-12-09 13:20:11 PST 
Comment on attachment 296679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296679&action=review

> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:988
> +        defaultItemIdentifiers = passwordTextTouchBarDefaultItemIdentifiers();

Should we allow the user to customize out the text candidates item while the password text touch bar is open?
Comment 4 Beth Dakin 2016-12-09 13:45:00 PST 
(In reply to comment #3)
> Comment on attachment 296679 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296679&action=review
> 
> > Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:988
> > +        defaultItemIdentifiers = passwordTextTouchBarDefaultItemIdentifiers();
> 
> Should we allow the user to customize out the text candidates item while the
> password text touch bar is open?

This is definitely debatable. I decided not to make it customizable since most of the other password fields on macOS are not customizable. (Then again, most other password fields are also blank and not blank candidates.) It does still honor the typing suggestions system preference. We should keep thinking about this.
Comment 5 Beth Dakin 2016-12-09 14:01:29 PST 
Thanks Wenson! https://trac.webkit.org/changeset/209626