Bug 165673 – Password fields should not show the emoji button in TouchBar

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Beth Dakin]

Passsword fields should not show the emoji button in TouchBar

rdar://problem/29235739

[Beth Dakin]

Created attachment 296679 [details]
Patch

[WebKit Commit Bot]

Attachment 296679 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1100:  Extra space in capture list.  [whitespace/brackets] [4]
ERROR: Source/WebKit/mac/WebView/WebView.mm:9546:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Wenson Hsieh]

Comment on attachment 296679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296679&action=review

> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:988
> +        defaultItemIdentifiers = passwordTextTouchBarDefaultItemIdentifiers();

Should we allow the user to customize out the text candidates item while the password text touch bar is open?

[Beth Dakin]

(In reply to comment #3)
> Comment on attachment 296679 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296679&action=review
> 
> > Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:988
> > +        defaultItemIdentifiers = passwordTextTouchBarDefaultItemIdentifiers();
> 
> Should we allow the user to customize out the text candidates item while the
> password text touch bar is open?

This is definitely debatable. I decided not to make it customizable since most of the other password fields on macOS are not customizable. (Then again, most other password fields are also blank and not blank candidates.) It does still honor the typing suggestions system preference. We should keep thinking about this.

[Beth Dakin]

Thanks Wenson! https://trac.webkit.org/changeset/209626