Bug 165664 – WebView doesn't become first responder in element fullscreen.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jeremy Jones]

WebView doesn't become first responder in element fullscreen.

[Jeremy Jones]

Created attachment 296663 [details]
Patch

[Jeremy Jones]

rdar://problem/28927252

[Tim Horton]

Comment on attachment 296663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296663&action=review

> Source/WebKit2/ChangeLog:12
> +        This change wait until after the contentView is visible to make the web view the first responder.

"This change wait until"

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:619
> +    [window makeFirstResponder:_webView];

Does makeResponderFirstResponderIfDescendantOfView do something important? Should you still use that? It seems like it had to be there for a reason.

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 296663 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296663&action=review
> 
> > Source/WebKit2/ChangeLog:12
> > +        This change wait until after the contentView is visible to make the web view the first responder.
> 
> "This change wait until"

"waits"

Done.

> 
> > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:619
> > +    [window makeFirstResponder:_webView];
> 
> Does makeResponderFirstResponderIfDescendantOfView do something important?
> Should you still use that? It seems like it had to be there for a reason.

It only makes the webView the first responder if if was already first responder while inline. However, it doesn't make sense to prevent web view from becoming first responder just because some search field in the app was first responder when entering fullscreen.

[Jeremy Jones]

(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 296663 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=296663&action=review
> > 
> > > Source/WebKit2/ChangeLog:12
> > > +        This change wait until after the contentView is visible to make the web view the first responder.
> > 
> > "This change wait until"
> 
> "waits"
> 
> Done.
> 
> > 
> > > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:619
> > > +    [window makeFirstResponder:_webView];
> > 
> > Does makeResponderFirstResponderIfDescendantOfView do something important?
> > Should you still use that? It seems like it had to be there for a reason.
> 
> It only makes the webView the first responder if if was already first
> responder while inline. However, it doesn't make sense to prevent web view
> from becoming first responder just because some search field in the app was
> first responder when entering fullscreen.

It is useful when exiting fullscreen to prevent the web view from stealing first responder from the app when exiting fullscreen.

[Tim Horton]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Comment on attachment 296663 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=296663&action=review
> > > 
> > > > Source/WebKit2/ChangeLog:12
> > > > +        This change wait until after the contentView is visible to make the web view the first responder.
> > > 
> > > "This change wait until"
> > 
> > "waits"
> > 
> > Done.
> > 
> > > 
> > > > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:619
> > > > +    [window makeFirstResponder:_webView];
> > > 
> > > Does makeResponderFirstResponderIfDescendantOfView do something important?
> > > Should you still use that? It seems like it had to be there for a reason.
> > 
> > It only makes the webView the first responder if if was already first
> > responder while inline. However, it doesn't make sense to prevent web view
> > from becoming first responder just because some search field in the app was
> > first responder when entering fullscreen.
> 
> It is useful when exiting fullscreen to prevent the web view from stealing
> first responder from the app when exiting fullscreen.

Ah, makes sense. WK2r=me

[Jeremy Jones]

Created attachment 296670 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 296670 [details]
Patch for landing.

Clearing flags on attachment: 296670

Committed r209624: <http://trac.webkit.org/changeset/209624>