Bug 165663 - Moved OrdinalNumber into its own file
Summary: Moved OrdinalNumber into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 10:48 PST by Geoffrey Garen
Modified: 2016-12-09 12:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (12.02 KB, patch)
2016-12-09 10:51 PST, Geoffrey Garen 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-12-09 10:48:57 PST 
Moved OrdinalNumber into its own file
Comment 1 Geoffrey Garen 2016-12-09 10:51:03 PST 
Created attachment 296661 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-09 10:52:25 PST 
Attachment 296661 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/text/OrdinalNumber.h:36:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/OrdinalNumber.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2016-12-09 11:23:13 PST 
Committed r209618: <http://trac.webkit.org/changeset/209618>
Comment 4 Joseph Pecoraro 2016-12-09 11:27:25 PST 
Comment on attachment 296661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296661&action=review

> Source/WTF/WTF.xcodeproj/project.pbxproj:93
> +		14E785E81DFB330100209BD1 /* OrdinalNumber.h in Headers */ = {isa = PBXBuildFile; fileRef = 14E785E71DFB330100209BD1 /* OrdinalNumber.h */; settings = {ATTRIBUTES = (Private, ); }; };

What does it mean for this to be a Private? I notice no other files have that attribute, including TextPosition.h.
Comment 5 Geoffrey Garen 2016-12-09 12:15:16 PST 
That's how Xcode usually marks a header to indicate that other frameworks can #include it. The alternative, "Project", means only things in the WTF project can #include the header. I'm surprised that TextPosition didn't need this. Not sure what's going on there.