Bug 165663 – Moved OrdinalNumber into its own file

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

Moved OrdinalNumber into its own file

[Geoffrey Garen]

Created attachment 296661 [details]
Patch

[WebKit Commit Bot]

Attachment 296661 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/text/OrdinalNumber.h:36:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/OrdinalNumber.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Committed r209618: <http://trac.webkit.org/changeset/209618>

[Joseph Pecoraro]

Comment on attachment 296661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296661&action=review

> Source/WTF/WTF.xcodeproj/project.pbxproj:93
> +		14E785E81DFB330100209BD1 /* OrdinalNumber.h in Headers */ = {isa = PBXBuildFile; fileRef = 14E785E71DFB330100209BD1 /* OrdinalNumber.h */; settings = {ATTRIBUTES = (Private, ); }; };

What does it mean for this to be a Private? I notice no other files have that attribute, including TextPosition.h.

[Geoffrey Garen]

That's how Xcode usually marks a header to indicate that other frameworks can #include it. The alternative, "Project", means only things in the WTF project can #include the header. I'm surprised that TextPosition didn't need this. Not sure what's going on there.