Bug 165661 - [Cocoa] Validation message for required checkbox doesn’t conform the the Apple Style Guide
Summary: [Cocoa] Validation message for required checkbox doesn’t conform the the Appl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 10:28 PST by mitz
Modified: 2016-12-09 11:43 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.66 KB, patch)
2016-12-09 10:38 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-12-09 10:28:38 PST 
The form validation message for a required checkbox says “Check this box”. The Apple Style Guide says not to use “check” as a verb “when you mean the action of clicking a checkbox to select an option”. It also says “You select or deselect a checkbox”. It goes on to give this as an example of correct usage: “Select the ‘Object causes wrap’ checkbox”.

So at least on Apple platforms, I think the validation message should be “Select this checkbox” instead of “Check this box”.
Comment 1 Chris Dumez 2016-12-09 10:38:17 PST 
Created attachment 296660 [details]
Patch
Comment 2 mitz 2016-12-09 10:42:28 PST 
Comment on attachment 296660 [details]
Patch

Thanks!
Comment 3 Chris Dumez 2016-12-09 11:43:14 PST 
Comment on attachment 296660 [details]
Patch

Clearing flags on attachment: 296660

Committed r209620: <http://trac.webkit.org/changeset/209620>
Comment 4 Chris Dumez 2016-12-09 11:43:18 PST 
All reviewed patches have been landed.  Closing bug.