Bug 165660 - [Modern Media Controls] Implement the pageScaleFactor property
Summary: [Modern Media Controls] Implement the pageScaleFactor property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 10:04 PST by Antoine Quint
Modified: 2016-12-09 10:29 PST (History)
0 users

See Also:

Attachments
Patch (10.78 KB, patch)
2016-12-09 10:08 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-12-09 10:04:57 PST 
[Modern Media Controls] Implement the pageScaleFactor property
Comment 1 Antoine Quint 2016-12-09 10:08:35 PST 
Created attachment 296657 [details]
Patch
Comment 2 Dean Jackson 2016-12-09 10:14:29 PST 
Comment on attachment 296657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296657&action=review

> Source/WebCore/ChangeLog:16
> +        We are also fixing HTMLMediaElement such that we no longer hit a JSC assertion when trying
> +        to set the pageScaleFactor property before the JS controller was actually created.

This should probably be in the ChangeLog details.
Comment 3 Antoine Quint 2016-12-09 10:29:15 PST 
https://trac.webkit.org/changeset/209615