Bug 165657 - LinkIconCollector refactoring
Summary: LinkIconCollector refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 09:33 PST by Brady Eidson
Modified: 2016-12-09 21:57 PST (History)
4 users (show)

See Also:

Attachments
Patch (9.07 KB, patch)
2016-12-09 10:14 PST, Brady Eidson 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-12-09 09:33:59 PST 
LinkIconCollector refactoring
Comment 1 Brady Eidson 2016-12-09 10:14:25 PST 
Created attachment 296658 [details]
Patch
Comment 2 Brady Eidson 2016-12-09 10:22:25 PST 
https://trac.webkit.org/changeset/209613
Comment 3 Darin Adler 2016-12-09 21:25:36 PST 
Comment on attachment 296658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296658&action=review

> Source/WebCore/platform/LinkIcon.h:38
> +    String mimeType;

Why add this? It seems to be write-only.
Comment 4 Brady Eidson 2016-12-09 21:57:41 PST 
(In reply to comment #3)
> Comment on attachment 296658 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296658&action=review
> 
> > Source/WebCore/platform/LinkIcon.h:38
> > +    String mimeType;
> 
> Why add this? It seems to be write-only.

Sorry, context missed by not being around in person while this was going on.

This was simply breaking off part of a larger patch to ease future review. The rest of that landed today (and does make use of this field)