RESOLVED FIXED 165657
LinkIconCollector refactoring 
https://bugs.webkit.org/show_bug.cgi?id=165657
Summary LinkIconCollector refactoring
Brady Eidson
Reported 2016-12-09 09:33:59 PST
LinkIconCollector refactoring
Attachments
Patch (9.07 KB, patch)
2016-12-09 10:14 PST, Brady Eidson 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-12-09 10:14:25 PST
Created attachment 296658 [details] Patch
Brady Eidson
Comment 2 2016-12-09 10:22:25 PST
https://trac.webkit.org/changeset/209613
Darin Adler
Comment 3 2016-12-09 21:25:36 PST
Comment on attachment 296658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296658&action=review > Source/WebCore/platform/LinkIcon.h:38 > + String mimeType; Why add this? It seems to be write-only.
Brady Eidson
Comment 4 2016-12-09 21:57:41 PST
(In reply to comment #3) > Comment on attachment 296658 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296658&action=review > > > Source/WebCore/platform/LinkIcon.h:38 > > + String mimeType; > > Why add this? It seems to be write-only. Sorry, context missed by not being around in person while this was going on. This was simply breaking off part of a larger patch to ease future review. The rest of that landed today (and does make use of this field)
Note You need to log in before you can comment on or make changes to this bug.