RESOLVED FIXED 165648
Web Inspector: Frontend should not be resetting TypeProfiler state when switching between ContentViews 
https://bugs.webkit.org/show_bug.cgi?id=165648
Summary Web Inspector: Frontend should not be resetting TypeProfiler state when switc...
Joseph Pecoraro
Reported 2016-12-08 20:13:23 PST
Summary: Frontend should not be resetting TypeProfiler state when switching between ContentViews Right now, every time we switch between two different resources we are sending Runtime.disableTypeProfiler / Runtime.disableControlFlowProfiler (or enable if the feature is on). We should only be toggling the backends when the state changes, not for every single resource. Steps to Reproduce: 1. Inspect this page 2. Select a JavaScript Resource => Runtime commands sent 3. Select another JavaScript Resource => The same Runtime commands are sent
Attachments
[PATCH] Proposed Fix (5.21 KB, patch)
2016-12-08 20:21 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-12-08 20:21:29 PST
Created attachment 296628 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 2 2016-12-09 14:12:09 PST
<rdar://problem/29602027>
Nikita Vasilyev
Comment 3 2016-12-09 14:18:01 PST
Looks good! I was planning on doing very similar change in bug 163345: Web Inspector: Disable Type and Code Coverage profilers while timeline is being recorded.
Blaze Burg
Comment 4 2016-12-09 14:18:21 PST
Comment on attachment 296628 [details] [PATCH] Proposed Fix rs=me
WebKit Commit Bot
Comment 5 2016-12-09 14:44:24 PST
Comment on attachment 296628 [details] [PATCH] Proposed Fix Clearing flags on attachment: 296628 Committed r209631: <http://trac.webkit.org/changeset/209631>
WebKit Commit Bot
Comment 6 2016-12-09 14:44:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.