Bug 165647 - DisallowUserAgentShadowContent moves out of non-UA shadow roots
Summary: DisallowUserAgentShadowContent moves out of non-UA shadow roots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords:
Depends on:
Blocks: 148695
  Show dependency tree / graph
 
Reported: 2016-12-08 20:07 PST by Ryosuke Niwa
Modified: 2017-07-16 19:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.97 KB, patch)
2017-07-14 16:39 PDT, Ali Juma 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-elcapitan (1.82 MB, application/zip)
2017-07-14 17:59 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-12-08 20:07:58 PST 
When DisallowUserAgentShadowContent is set, we always move out of all shadow roots
regardless of whether they’re UA shadow root or not.
Comment 1 Ali Juma 2017-07-14 16:39:00 PDT 
Created attachment 315500 [details]
Patch
Comment 2 Build Bot 2017-07-14 17:59:22 PDT 
Comment on attachment 315500 [details]
Patch

Attachment 315500 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4122481

New failing tests:
security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html
Comment 3 Build Bot 2017-07-14 17:59:23 PDT 
Created attachment 315512 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Ryosuke Niwa 2017-07-16 18:42:26 PDT 
Thanks for the fix!
Comment 5 WebKit Commit Bot 2017-07-16 19:10:45 PDT 
Comment on attachment 315500 [details]
Patch

Clearing flags on attachment: 315500

Committed r219551: <http://trac.webkit.org/changeset/219551>
Comment 6 WebKit Commit Bot 2017-07-16 19:10:46 PDT 
All reviewed patches have been landed.  Closing bug.