Bug 165645 – [CSS Parser] Remove the old CSS Parser

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dave Hyatt]

[CSS Parser] Remove the old CSS Parser

[Dave Hyatt]

Created attachment 296616 [details]
Patch

[Dave Hyatt]

Created attachment 296621 [details]
Patch

[Dave Hyatt]

Created attachment 296632 [details]
Patch

[Dave Hyatt]

Created attachment 296634 [details]
Patch

[Build Bot]

Comment on attachment 296634 [details]
Patch

Attachment 296634 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2661712

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 296637 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296634 [details]
Patch

Attachment 296634 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2662087

New failing tests:
media/media-document-audio-repaint.html
media/video-volume-slider.html
fast/text/font-face-crash.html
media/audio-controls-rendering.html
fast/text/font-face-javascript.html
fast/text/font-face-crash-2.html
fast/text/font-face-set-ready-fire.html
fast/text/font-face-set-cssom.html
media/controls-without-preload.html
fast/dom/HTMLFontElement/face-attribute.html
inspector/css/shadow-scoped-style.html
media/controls-after-reload.html
security/contentSecurityPolicy/font-loading-block-all.html
inspector/css/stylesheet-with-mutations.html
fullscreen/video-cursor-auto-hide.html
fast/text/font-face-empty-string.html
media/controls-styling.html
fast/text/css-font-loading-arraybuffer.html
svg/custom/fill-SVGPaint-interface.svg
media/video-controls-rendering.html
fast/text/font-face-set-javascript.html
inspector/css/generate-css-rule-string.html
media/video-no-audio.html
media/controls-strict.html
fast/text/font-face-set-document.html
media/video-display-toggle.html
sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.4_encodeURIComponent/S15.1.3.4_A5.6.html

[Build Bot]

Created attachment 296638 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296634 [details]
Patch

Attachment 296634 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2662187

New failing tests:
security/contentSecurityPolicy/font-loading-block-all.html
fast/text/font-face-set-ready-fire.html
fast/text/font-face-crash.html
media/controls-strict.html
fast/text/font-face-set-document.html
svg/custom/fill-SVGPaint-interface.svg
fast/text/font-face-crash-2.html
fast/text/css-font-loading-arraybuffer.html
fast/text/font-face-javascript.html
media/video-controls-rendering.html
media/controls-without-preload.html
fast/text/font-face-set-cssom.html
fast/dom/HTMLFontElement/face-attribute.html
fast/text/font-face-empty-string.html
fast/text/font-face-set-javascript.html

[Build Bot]

Created attachment 296644 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 296634 [details]
Patch

Attachment 296634 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2663510

New failing tests:
media/media-document-audio-repaint.html
media/video-volume-slider.html
fast/text/font-face-crash.html
media/audio-controls-rendering.html
fast/text/font-face-javascript.html
fast/text/font-face-crash-2.html
fast/text/font-face-set-ready-fire.html
fast/text/font-face-set-cssom.html
media/controls-without-preload.html
fast/dom/HTMLFontElement/face-attribute.html
inspector/css/shadow-scoped-style.html
security/contentSecurityPolicy/font-loading-block-all.html
inspector/css/stylesheet-with-mutations.html
fullscreen/video-cursor-auto-hide.html
fast/text/font-face-empty-string.html
fast/text/css-font-loading-arraybuffer.html
svg/custom/fill-SVGPaint-interface.svg
media/video-controls-rendering.html
fast/text/font-face-set-javascript.html
inspector/css/generate-css-rule-string.html
media/video-no-audio.html
media/controls-strict.html
fast/text/font-face-set-document.html
media/video-display-toggle.html

[Build Bot]

Created attachment 296646 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Alex Christensen]

Oh boy!  Once this is done, can we check in the generated XPathGrammar.cpp and not require bison to build webkit any more?

[Alex Christensen]

or flex

[Dave Hyatt]

Cleared review flag for now, since I need to do some work on FontFace, which was still using the old parser (ugh).

[Dave Hyatt]

Created attachment 296671 [details]
Patch

[Dave Hyatt]

Created attachment 296672 [details]
Patch

[Dave Hyatt]

Created attachment 296680 [details]
Patch

[WebKit Commit Bot]

Attachment 296680 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSRule.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 58 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 296684 [details]
Patch

[WebKit Commit Bot]

Attachment 296684 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSRule.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/mac/DOM/DOMCSSRule.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 61 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296684 [details]
Patch

Attachment 296684 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2681342

New failing tests:
media/media-document-audio-repaint.html
media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/controls-after-reload.html

[Build Bot]

Created attachment 296700 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296684 [details]
Patch

Attachment 296684 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2681268

New failing tests:
media/media-document-audio-repaint.html
media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/controls-after-reload.html

[Build Bot]

Created attachment 296701 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Ryosuke Niwa]

Can we add fontset support in a separate patch?

[Build Bot]

Comment on attachment 296684 [details]
Patch

Attachment 296684 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2681366

New failing tests:
media/controls-without-preload.html
media/video-controls-rendering.html
media/controls-strict.html

[Build Bot]

Created attachment 296707 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 296684 [details]
Patch

Attachment 296684 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2681777

New failing tests:
media/media-document-audio-repaint.html
media/video-no-audio.html
media/controls-strict.html
js/dom/global-constructors-attributes.html
media/video-volume-slider.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-controls-rendering.html
media/controls-without-preload.html

[Build Bot]

Created attachment 296720 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Dave Hyatt]

Created attachment 296742 [details]
Patch

[WebKit Commit Bot]

Attachment 296742 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSRule.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/mac/DOM/DOMCSSRule.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 59 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 296751 [details]
Patch

[WebKit Commit Bot]

Attachment 296751 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSRule.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/mac/DOM/DOMCSSRule.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 59 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 296757 [details]
Patch

[WebKit Commit Bot]

Attachment 296757 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSRule.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/mac/DOM/DOMCSSRule.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 59 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 296761 [details]
Patch

[WebKit Commit Bot]

Attachment 296761 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSRule.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/mac/DOM/DOMCSSRule.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 59 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296761 [details]
Patch

Attachment 296761 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2684494

New failing tests:
js/dom/global-constructors-attributes.html

[Build Bot]

Created attachment 296771 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Daniel Bates]

Comment on attachment 296761 [details]
Patch

Let's display: none this code!

[Dave Hyatt]

Created attachment 296784 [details]
Patch

[WebKit Commit Bot]

Attachment 296784 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSRule.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/mac/DOM/DOMCSSRule.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296784 [details]
Patch

Attachment 296784 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2687271

New failing tests:
inspector/codemirror/prettyprinting-css-rules.html

[Build Bot]

Created attachment 296801 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Dave Hyatt]

The inspector crash is not related to my patch, even though EWS claims it is.

[Dave Hyatt]

Landed in r209666.

[Dave Hyatt]

This broke a couple of TestWebkitAPI tests, but I have a fix up in:

https://bugs.webkit.org/show_bug.cgi?id=165737