Bug 165642 – FileHandle::printf doesn't build on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Keith Rollin]

vasprintf doesn't exist on Windows.

[Keith Rollin]

Created attachment 296609 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 296609 [details]
Patch

Clearing flags on attachment: 296609

Committed r209593: <http://trac.webkit.org/changeset/209593>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 296609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296609&action=review

> Source/WebCore/platform/FileHandle.cpp:105
> +    // TODO: implement this without relying on vasprintf.
> +    return false;

Looked up how to do it here <http://en.cppreference.com/w/cpp/io/c/vfprintf>:

    va_list args;
    va_start(args, format);

    va_list preflightArgs;
    va_copy(preflightArgs, args);
    Vector<char, 1024> buffer { 1 + std::vsnprintf(nullptr, 0, format, preflightArgs) };
    va_end(preflightArgs);

    std::vsnprintf(buffer.data(), buffer.size(), format, args);

    va_end(args);

    return write(buffer.data(), strlen(buffer.data()));

[Darin Adler]

That version should work fine on other platforms too.

[Darin Adler]

I put up a patch with the above code in bug 165740.