Bug 165637 - [Modern Media Controls] Remaining time label first appears way to the left
Summary: [Modern Media Controls] Remaining time label first appears way to the left
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-08 17:07 PST by Antoine Quint
Modified: 2016-12-09 07:35 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.69 KB, patch)
2016-12-08 17:13 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (5.70 KB, patch)
2016-12-08 18:15 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-12-08 17:07:39 PST
[Modern Media Controls] Remaining time label first appears way to the left
Comment 1 Antoine Quint 2016-12-08 17:13:03 PST
Created attachment 296597 [details]
Patch
Comment 2 Dean Jackson 2016-12-08 18:01:37 PST
Comment on attachment 296597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296597&action=review

> Source/WebCore/ChangeLog:15
> +        We would sometimes see the remaining time label be laid out in an incorrect position
> +        when a video would start playing because the time label was being committed from a
> +        previous value before, in the same frame, we would call the layout() function
> +        of MacOSInlineMediaControls which would set the newly computed location for the
> +        remaining time label, but because we would reset the list of dirty properties after
> +        calling all layout functions, the new value set in MacOSInlineMediaControls.layout()
> +        woudl be disregarded and the wrong, commited value would persist until it was reset
> +        in a much later frame.

This is an extremely confusing 97 word sentence. Can you be a bit more clear?

Also typo: woudl + commited
Comment 3 Antoine Quint 2016-12-08 18:15:56 PST
Created attachment 296607 [details]
Patch for landing
Comment 4 Antoine Quint 2016-12-09 07:35:38 PST
https://trac.webkit.org/changeset/209607