Bug 165629 - [WebCrypto] Remove NoInterfaceObject attribute from SubtleCrypto Interface
Summary: [WebCrypto] Remove NoInterfaceObject attribute from SubtleCrypto Interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 159638
  Show dependency tree / graph
 
Reported: 2016-12-08 15:13 PST by Jiewen Tan
Modified: 2016-12-09 01:16 PST (History)
9 users (show)

See Also:

Attachments
Patch (8.08 KB, patch)
2016-12-08 16:03 PST, Jiewen Tan 		cdumez: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (1.29 MB, application/zip)
2016-12-08 17:00 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.69 MB, application/zip)
2016-12-08 17:18 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.49 MB, application/zip)
2016-12-08 17:45 PST, Build Bot 		no flags Details
Patch for landing (11.80 KB, patch)
2016-12-08 18:00 PST, Jiewen Tan 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (9.50 MB, application/zip)
2016-12-08 18:07 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.51 MB, application/zip)
2016-12-08 19:39 PST, Build Bot 		no flags Details
Patch for landing (13.36 KB, patch)
2016-12-08 20:35 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2016-12-08 15:13:15 PST 
Remove NoInterfaceObject attribute from SubtleCrypto Interface.
Comment 1 Jiewen Tan 2016-12-08 16:01:38 PST 
<rdar://problem/29586203>
Comment 2 Jiewen Tan 2016-12-08 16:03:49 PST 
Created attachment 296584 [details]
Patch
Comment 3 Chris Dumez 2016-12-08 16:04:52 PST 
Comment on attachment 296584 [details]
Patch

r=me but there are likely other tests that will need rebaselining.
Comment 4 Jiewen Tan 2016-12-08 16:10:02 PST 
(In reply to comment #3)
> Comment on attachment 296584 [details]
> Patch
> 
> r=me but there are likely other tests that will need rebaselining.

Thanks, Chris. Let's wait for the EWS results.
Comment 5 Build Bot 2016-12-08 17:00:33 PST 
Comment on attachment 296584 [details]
Patch

Attachment 296584 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2656953

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html
Comment 6 Build Bot 2016-12-08 17:00:37 PST 
Created attachment 296595 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-12-08 17:17:58 PST 
Comment on attachment 296584 [details]
Patch

Attachment 296584 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2657056

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html
Comment 8 Build Bot 2016-12-08 17:18:01 PST 
Created attachment 296598 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-12-08 17:45:22 PST 
Comment on attachment 296584 [details]
Patch

Attachment 296584 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2657546

New failing tests:
js/dom/global-constructors-attributes.html
js/dom/global-constructors-attributes-dedicated-worker.html
Comment 10 Build Bot 2016-12-08 17:45:25 PST 
Created attachment 296604 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 11 Jiewen Tan 2016-12-08 18:00:15 PST 
Created attachment 296605 [details]
Patch for landing
Comment 12 Build Bot 2016-12-08 18:07:20 PST 
Comment on attachment 296584 [details]
Patch

Attachment 296584 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2657679

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html
Comment 13 Build Bot 2016-12-08 18:07:24 PST 
Created attachment 296606 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2016-12-08 19:39:35 PST 
Comment on attachment 296605 [details]
Patch for landing

Attachment 296605 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2659317

New failing tests:
js/dom/global-constructors-attributes.html
Comment 15 Build Bot 2016-12-08 19:39:38 PST 
Created attachment 296622 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 16 Jiewen Tan 2016-12-08 20:35:45 PST 
Created attachment 296631 [details]
Patch for landing
Comment 17 WebKit Commit Bot 2016-12-08 23:46:26 PST 
Comment on attachment 296631 [details]
Patch for landing

Clearing flags on attachment: 296631

Committed r209598: <http://trac.webkit.org/changeset/209598>