Bug 165622 - Defer sending Mach messages if the queue is full
Summary: Defer sending Mach messages if the queue is full
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
: 129896 149585 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-08 13:07 PST by Anders Carlsson
Modified: 2016-12-14 09:27 PST (History)
7 users (show)

See Also:


Attachments
Patch (11.17 KB, patch)
2016-12-08 13:15 PST, Anders Carlsson
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-12-08 13:07:57 PST
Defer sending Mach messages if the queue is full
Comment 1 Anders Carlsson 2016-12-08 13:15:28 PST
Created attachment 296556 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-08 13:17:56 PST
Attachment 296556 [details] did not pass style-queue:


ERROR: Source/WebKit2/Platform/IPC/mac/MachMessage.cpp:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:81:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2016-12-08 14:54:28 PST
Committed r209575: <http://trac.webkit.org/changeset/209575>
Comment 4 BJ Burg 2016-12-13 13:06:15 PST
Comment on attachment 296556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296556&action=review

> Source/WebKit2/Platform/IPC/mac/MachMessage.h:49
> +    bool m_shouldFreeDescriptors;

Any reason to not initialize here?
Comment 5 Alexey Proskuryakov 2016-12-14 09:26:09 PST
*** Bug 129896 has been marked as a duplicate of this bug. ***
Comment 6 Alexey Proskuryakov 2016-12-14 09:27:00 PST
*** Bug 149585 has been marked as a duplicate of this bug. ***