Bug 165599 - [Readable Streams API] Implement ReadableByteStreamController desiredSize
Summary: [Readable Streams API] Implement ReadableByteStreamController desiredSize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Romain Bellessort
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-08 07:10 PST by Romain Bellessort
Modified: 2016-12-12 08:00 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.66 KB, patch)
2016-12-08 07:44 PST, Romain Bellessort 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Bellessort 2016-12-08 07:10:57 PST 
Implement ReadableByteStreamController desiredSize
Comment 1 Romain Bellessort 2016-12-08 07:44:59 PST 
Created attachment 296513 [details]
Patch
Comment 2 Alex Christensen 2016-12-09 09:44:47 PST 
Comment on attachment 296513 [details]
Patch

Can desiredSize be set to values other than 1?  I think that should be tested, as well as actually getting bytes and showing that the desiredSize is actually used correctly.
Comment 3 Darin Adler 2016-12-09 21:30:41 PST 
Comment on attachment 296513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296513&action=review

> LayoutTests/streams/readable-byte-stream-controller-expected.txt:13
> +PASS By default initial value of desiredSize should be 1 

This does not seem to be sufficient testing.
Comment 4 WebKit Commit Bot 2016-12-09 21:56:43 PST 
Comment on attachment 296513 [details]
Patch

Clearing flags on attachment: 296513

Committed r209649: <http://trac.webkit.org/changeset/209649>
Comment 5 WebKit Commit Bot 2016-12-09 21:56:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Romain Bellessort 2016-12-12 08:00:23 PST 
(In reply to comment #2)
> Comment on attachment 296513 [details]
> Patch
> 
> Can desiredSize be set to values other than 1?  I think that should be
> tested, as well as actually getting bytes and showing that the desiredSize
> is actually used correctly.

(In reply to comment #3)
> Comment on attachment 296513 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296513&action=review
> 
> > LayoutTests/streams/readable-byte-stream-controller-expected.txt:13
> > +PASS By default initial value of desiredSize should be 1 
> 
> This does not seem to be sufficient testing.

For the moment, as the API is not yet fully implemented, desiredSize value cannot change. But my intent is to add more tests addressing desiredSize as other functions are implemented.