Bug 165581 – Web Inspector: ThreadTreeElement should have a "Resume" status button when paused

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

A context menu item exists, but having a status button that is revealed when the thread element is selected, or hovered, would improve discoverability.

[Matt Baker]

Created attachment 296463 [details]
Patch

[Blaze Burg]

Please make screenshot.

[Matt Baker]

Created attachment 296464 [details]
[Image] Hovered tree element

[Matt Baker]

Created attachment 296465 [details]
[Image] Selected tree element

[Joseph Pecoraro]

Comment on attachment 296463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296463&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.js:133
> +        if (!DebuggerAgent.continueUntilNextRunLoop)
> +            return;

I don't think this will be necessary. Any frontend that shows Workers has this backend support.

> Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.js:40
> +        this._element.addEventListener("mousedown", (event) => {
> +            // Prevent tree element from being selected.
> +            event.stopPropagation();
> +        });

I think this should probably be done on a case by case basis. It seems this would make clicking on the Loading indicator for incomplete resources do nothing instead of selecting the resource.

[Matt Baker]

(In reply to comment #5)
> Comment on attachment 296463 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296463&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.js:133
> > +        if (!DebuggerAgent.continueUntilNextRunLoop)
> > +            return;
> 
> I don't think this will be necessary. Any frontend that shows Workers has
> this backend support.
> 
> > Source/WebInspectorUI/UserInterface/Views/TreeElementStatusButton.js:40
> > +        this._element.addEventListener("mousedown", (event) => {
> > +            // Prevent tree element from being selected.
> > +            event.stopPropagation();
> > +        });
> 
> I think this should probably be done on a case by case basis. It seems this
> would make clicking on the Loading indicator for incomplete resources do
> nothing instead of selecting the resource.

Good point! Will fix.

[Matt Baker]

Created attachment 296886 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 296886 [details]
Patch for landing

Clearing flags on attachment: 296886

Committed r209698: <http://trac.webkit.org/changeset/209698>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.