Bug 165564 - Add more missing trivial wasm ops.
Summary: Add more missing trivial wasm ops.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-07 16:27 PST by Keith Miller
Modified: 2016-12-07 17:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.59 KB, patch)
2016-12-07 16:50 PST, Keith Miller 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-07 16:27:16 PST 
Add more missing trivial wasm ops.
Comment 1 Keith Miller 2016-12-07 16:50:58 PST 
Created attachment 296440 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-07 16:52:59 PST 
Attachment 296440 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:68:  [<lambda>] Undefined variable 'isUnary'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:68:  [<lambda>] Undefined variable 'isBinary'  [pylint/E0602] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2016-12-07 17:00:24 PST 
Comment on attachment 296440 [details]
Patch

r=me

Needs a Nop test.
Comment 4 Keith Miller 2016-12-07 17:14:09 PST 
Committed r209503: <http://trac.webkit.org/changeset/209503>