Bug 165563 - DumpRenderTree should stop using CheckedMalloc.
Summary: DumpRenderTree should stop using CheckedMalloc.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Reported: 2016-12-07 16:21 PST by Mark Lam
Modified: 2016-12-07 19:26 PST (History)
5 users (show)

See Also:

proposed patch. (12.57 KB, patch)
2016-12-07 16:32 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-12-07 16:21:32 PST
1. WebKitTestRunner does not have equivalent behavior to that which is implemented in CheckedMalloc.
2. bmalloc does not honor the settings of CheckedMalloc.

The only time CheckedMalloc comes into play is when DRT uses gmalloc or system malloc.  As a result, DRT exhibits different behavior from the normal way we run our tests.  We should obsolete CheckedMalloc and make DRT behave consistently with WKTR.
Comment 1 Mark Lam 2016-12-07 16:22:19 PST
Comment 2 Mark Lam 2016-12-07 16:32:43 PST
Created attachment 296436 [details]
proposed patch.
Comment 3 Geoffrey Garen 2016-12-07 16:42:59 PST
Comment on attachment 296436 [details]
proposed patch.

Comment 4 Alexey Proskuryakov 2016-12-07 18:17:35 PST
For reference, this code was added in bug 7655 to silence noise in the logs. We eitehr no longer have such tests, or don't care about the noise as much as before.
Comment 5 WebKit Commit Bot 2016-12-07 19:26:38 PST
Comment on attachment 296436 [details]
proposed patch.

Clearing flags on attachment: 296436

Committed r209516: <http://trac.webkit.org/changeset/209516>
Comment 6 WebKit Commit Bot 2016-12-07 19:26:44 PST
All reviewed patches have been landed.  Closing bug.