Bug 165560 – Add hysteresis to ActivityState IsAudible & IsLoading flags

• Status: NEW
• Component: WebKit2

[Gavin Barraclough]

There is currently no hysteresis on IsAudible. This could potentially lead to stalls in audio playlists if completion of one track were to schedule a new track on a zero delay timer. Keep the audio playing flag fuzzily set for a few seconds after the last track stops, to give the page a brief chance to queue another track up before throttling kicks in. Similar for IsLoading.

[Gavin Barraclough]

Created attachment 296435 [details]
Fix

[WebKit Commit Bot]

Attachment 296435 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:364:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 296435 [details]
Fix

r=me

[Build Bot]

Comment on attachment 296435 [details]
Fix

Attachment 296435 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2646879

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 296446 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Gavin Barraclough]

Created attachment 296504 [details]
Retest

[WebKit Commit Bot]

Attachment 296504 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:363:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296504 [details]
Retest

Attachment 296504 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2650688

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 296506 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Gavin Barraclough]

Created attachment 296525 [details]
Retest

[Gavin Barraclough]

Created attachment 296526 [details]
Test

[WebKit Commit Bot]

Attachment 296525 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:363:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Attachment 296526 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:362:  Extra space after ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296525 [details]
Retest

Attachment 296525 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2654523

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 296537 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Gavin Barraclough]

Created attachment 296570 [details]
WebPage changes only

[Gavin Barraclough]

Created attachment 296587 [details]
WebPageProxy changes only

[WebKit Commit Bot]

Attachment 296587 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:363:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296587 [details]
WebPageProxy changes only

Attachment 296587 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2657457

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 296601 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6