Add the other tag names that should be returned as the role. See "document structure" https://wiki.mozilla.org/Accessibility/AT-Windows-API
Created attachment 296418 [details] Patch
Created attachment 296582 [details] Patch
Comment on attachment 296582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296582&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Why not? This certainly changes behavior. It should be possible to write a test that verifies that the behavior was changed.
Comment on attachment 296582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296582&action=review > Source/WebCore/ChangeLog:3 > + Added the other missing BSTR roles tag names. this line should be the name of the bug >> Source/WebCore/ChangeLog:8 >> + No new tests needed. > > Why not? This certainly changes behavior. It should be possible to write a test that verifies that the behavior was changed. agreed
On IRC they told me there should be no tests. > Comment on attachment 296582 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296582&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests needed. > > Why not? This certainly changes behavior. It should be possible to write a > test that verifies that the behavior was changed.
Created attachment 296847 [details] Patch
Comment on attachment 296847 [details] Patch You'll also need to add the test expectations file that is created when you run this test Thanks
Created attachment 296856 [details] Patch
Created attachment 296858 [details] Patch
This patch is not committed yet ???!
<rdar://problem/30474763>
(In reply to comment #10) > This patch is not committed yet ???! CQ flag is not set on this patch
Comment on attachment 296858 [details] Patch Clearing flags on attachment: 296858 Committed r212270: <http://trac.webkit.org/changeset/212270>
All reviewed patches have been landed. Closing bug.