Bug 165545 - WebCore::AccessibilityRenderObject add the other missing BSTR roles tag names.
Summary: WebCore::AccessibilityRenderObject add the other missing BSTR roles tag names.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-07 13:42 PST by Karim
Modified: 2017-02-13 18:12 PST (History)
11 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2016-12-07 13:56 PST, Karim
no flags Details | Formatted Diff | Diff
Patch (2.08 KB, patch)
2016-12-08 16:01 PST, Karim
no flags Details | Formatted Diff | Diff
Patch (6.99 KB, patch)
2016-12-10 20:44 PST, Karim
no flags Details | Formatted Diff | Diff
Patch (8.42 KB, patch)
2016-12-10 23:31 PST, Karim
no flags Details | Formatted Diff | Diff
Patch (8.42 KB, patch)
2016-12-11 00:11 PST, Karim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karim 2016-12-07 13:42:08 PST
Add the other tag names that should be returned as the role.
See "document structure"
https://wiki.mozilla.org/Accessibility/AT-Windows-API
Comment 1 Karim 2016-12-07 13:56:55 PST
Created attachment 296418 [details]
Patch
Comment 2 Karim 2016-12-08 16:01:13 PST
Created attachment 296582 [details]
Patch
Comment 3 Alex Christensen 2016-12-09 09:49:20 PST
Comment on attachment 296582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296582&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Why not?  This certainly changes behavior.  It should be possible to write a test that verifies that the behavior was changed.
Comment 4 chris fleizach 2016-12-09 09:50:55 PST
Comment on attachment 296582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296582&action=review

> Source/WebCore/ChangeLog:3
> +        Added the other missing BSTR roles tag names.

this line should be the name of the bug

>> Source/WebCore/ChangeLog:8
>> +        No new tests needed.
> 
> Why not?  This certainly changes behavior.  It should be possible to write a test that verifies that the behavior was changed.

agreed
Comment 5 Karim 2016-12-09 09:56:34 PST
On IRC they told me there should be no tests.
> Comment on attachment 296582 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296582&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests needed.
> 
> Why not?  This certainly changes behavior.  It should be possible to write a
> test that verifies that the behavior was changed.
Comment 6 Karim 2016-12-10 20:44:54 PST
Created attachment 296847 [details]
Patch
Comment 7 chris fleizach 2016-12-10 21:23:52 PST
Comment on attachment 296847 [details]
Patch

You'll also need to add the test expectations file that is created when you run this test

Thanks
Comment 8 Karim 2016-12-10 23:31:49 PST
Created attachment 296856 [details]
Patch
Comment 9 Karim 2016-12-11 00:11:47 PST
Created attachment 296858 [details]
Patch
Comment 10 Karim 2017-02-10 15:56:11 PST
This patch is not committed yet ???!
Comment 11 Radar WebKit Bug Importer 2017-02-10 15:56:37 PST
<rdar://problem/30474763>
Comment 12 chris fleizach 2017-02-10 15:57:45 PST
(In reply to comment #10)
> This patch is not committed yet ???!

CQ flag is not set on this patch
Comment 13 WebKit Commit Bot 2017-02-13 18:12:47 PST
Comment on attachment 296858 [details]
Patch

Clearing flags on attachment: 296858

Committed r212270: <http://trac.webkit.org/changeset/212270>
Comment 14 WebKit Commit Bot 2017-02-13 18:12:52 PST
All reviewed patches have been landed.  Closing bug.