Bug 165540 - [WebCrypto] Replace webkitSubtle with subtle for all crypto/workers/subtle/ tests
Summary: [WebCrypto] Replace webkitSubtle with subtle for all crypto/workers/subtle/ t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords:
Depends on:
Blocks: 160880
  Show dependency tree / graph
 
Reported: 2016-12-07 12:59 PST by Jiewen Tan
Modified: 2016-12-09 01:16 PST (History)
4 users (show)

See Also:

Attachments
Patch (10.25 KB, patch)
2016-12-07 13:07 PST, Jiewen Tan 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (10.25 KB, patch)
2016-12-08 12:22 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2016-12-07 12:59:28 PST 
Replace webkitSubtle with subtle for all crypto/workers/subtle* tests.
Comment 1 Jiewen Tan 2016-12-07 13:07:39 PST 
Created attachment 296408 [details]
Patch
Comment 2 Brent Fulgham 2016-12-08 08:32:24 PST 
Comment on attachment 296408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296408&action=review

r=me, but please fix the 'verift" typo.

> LayoutTests/crypto/workers/subtle/resources/hrsa-postMessage-worker.js:19
> +            postMessage({ result:false, message:'publicKey.usages should be ["verift"]' });

"verift" -> "verify"
Comment 3 Jiewen Tan 2016-12-08 12:20:19 PST 
Comment on attachment 296408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296408&action=review

Thanks Brent for reviewing my patch.

>> LayoutTests/crypto/workers/subtle/resources/hrsa-postMessage-worker.js:19
>> +            postMessage({ result:false, message:'publicKey.usages should be ["verift"]' });
> 
> "verift" -> "verify"

Fixed.
Comment 4 Jiewen Tan 2016-12-08 12:22:36 PST 
Created attachment 296546 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-12-08 13:43:22 PST 
Comment on attachment 296546 [details]
Patch for landing

Clearing flags on attachment: 296546

Committed r209564: <http://trac.webkit.org/changeset/209564>