Support running the layout tests offline.
Created attachment 296402 [details] Patch
Created attachment 296403 [details] Patch
> + * web-platform-tests/.gitignore: Removed. We'll also need to remove svn properties: $ svn pl -v LayoutTests/imported/w3c/web-platform-tests Properties on 'LayoutTests/imported/w3c/web-platform-tests': svn:ignore .resources.url __init__.py resources .tools.url tools > + * web-platform-tests/.resources.url: Added. > + * web-platform-tests/.tools.url: Added. I believe that these are only needed for autoinstall.py, and don't need to be checked in (ditto for otehr .url files in the patch). Also, not sure if .gitmodules files are needed. I think that this patch also needs to remove autoinstall functionality from Tools/Scripts/webkitpy//layout_tests/servers/web_platform_test_server.py. Will we need to manually clean up these directories on all bots? Not sure if there is any way around that, other than changing paths.
(In reply to comment #3) > > + * web-platform-tests/.gitignore: Removed. > > We'll also need to remove svn properties: > > $ svn pl -v LayoutTests/imported/w3c/web-platform-tests > Properties on 'LayoutTests/imported/w3c/web-platform-tests': > svn:ignore > .resources.url > __init__.py > resources > .tools.url > tools I have no idea what this is, I am using GIT. > > > > + * web-platform-tests/.resources.url: Added. > > + * web-platform-tests/.tools.url: Added. > > I believe that these are only needed for autoinstall.py, and don't need to > be checked in (ditto for otehr .url files in the patch). There are definitely needed. If missing, the script will not be able to check which version is checked out locally and will re-download everything. > > Also, not sure if .gitmodules files are needed. Will take a look. > > I think that this patch also needs to remove autoinstall functionality from > Tools/Scripts/webkitpy//layout_tests/servers/web_platform_test_server.py. I will take a look but this did not cause any problem for me offline. > > Will we need to manually clean up these directories on all bots? Not sure if > there is any way around that, other than changing paths. Not sure I understand the question. Why would we need to clean them up? They're tracked in GIT now.
Created attachment 296415 [details] Patch
Created attachment 296416 [details] Patch
The reason the patch does not apply on the bots is because they have already a local copy of the tools checked out at the same location.
Created attachment 296432 [details] Patch
Comment on attachment 296432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296432&action=review > LayoutTests/imported/w3c/ChangeLog:12 > + * resources/web-platform-tests-modules/darobin/webidl2.js/archive/bd216bcd5596d60734450adc938155deab1e1a80.tar.gz: Added. MIT license: - https://github.com/w3c/webidl2.js/blob/develop/LICENSE > LayoutTests/imported/w3c/ChangeLog:13 > + * resources/web-platform-tests-modules/dontcallmedom/widlproc/archive/4ef8dde69c0ba3d0167bccfa2775eea7f0d6c7fe.tar.gz: Added. Apache License v2.0: - https://github.com/dontcallmedom/widlproc/blob/master/LICENSE > LayoutTests/imported/w3c/ChangeLog:14 > + * resources/web-platform-tests-modules/html5lib/html5lib-python/archive/7cce65bbaa78411f98b8b37eeefc9db03c580097.tar.gz: Added. MIT license: - https://github.com/html5lib/html5lib-python/blob/master/LICENSE > LayoutTests/imported/w3c/ChangeLog:15 > + * resources/web-platform-tests-modules/html5lib/html5lib-tests/archive/a9badff0cd2fe337170769d42ca2df5e96d30f97.tar.gz: Added. MIT License: - https://github.com/html5lib/html5lib-tests/blob/master/LICENSE > LayoutTests/imported/w3c/ChangeLog:16 > + * resources/web-platform-tests-modules/jgraham/six/archive/3b6173c833d217ab0186c355804f5925cbcfca47.tar.gz: Added. MIT license: - https://github.com/jgraham/six/blob/master/LICENSE > LayoutTests/imported/w3c/ChangeLog:17 > + * resources/web-platform-tests-modules/pytest-dev/pytest/archive/168daaa71f4cc5f846064ebebab41b9cf625a89a.tar.gz: Added. MIT license: - https://github.com/pytest-dev/pytest/blob/master/LICENSE > LayoutTests/imported/w3c/ChangeLog:18 > + * resources/web-platform-tests-modules/w3c/pywebsocket/archive/8c285d9015121e8c1c40be852439fc03b4a18112.tar.gz: Added. BSD license: - https://github.com/w3c/pywebsocket/blob/master/src/COPYING > LayoutTests/imported/w3c/ChangeLog:19 > + * resources/web-platform-tests-modules/w3c/testharness.js/archive/873f9680aff66553f84d38f21a038c4534cc2789.tar.gz: Added. BSD license: - https://github.com/w3c/testharness.js/blob/master/LICENSE > LayoutTests/imported/w3c/ChangeLog:20 > + * resources/web-platform-tests-modules/w3c/wdclient/archive/de9b46ec049f0b2a6fe261e27804970535ba8658.tar.gz: Added. Mozilla public license v2.0: - https://github.com/w3c/wdclient/blob/master/COPYING > LayoutTests/imported/w3c/ChangeLog:21 > + * resources/web-platform-tests-modules/w3c/wpt-tools/archive/cf9748586c2bca14998eda5956be6cf4d6d221d9.tar.gz: Added. BSD license: - https://github.com/w3c/wpt-tools/blob/master/LICENSE > LayoutTests/imported/w3c/ChangeLog:22 > + * resources/web-platform-tests-modules/w3c/wptserve/archive/071c51e26a57300979ad53313970d7247979f6d3.tar.gz: Added. BSD license: - https://github.com/w3c/wptserve/blob/master/LICENSE
Comment on attachment 296432 [details] Patch I think this approach is okay for now although I’m totally opposed to checking in files individually.
(In reply to comment #10) > Comment on attachment 296432 [details] > Patch > > I think this approach is okay for now although I’m totally opposed to > checking in files individually. I think you mean that you would NOT be opposed to checking in files individually.
Comment on attachment 296432 [details] Patch Clearing flags on attachment: 296432 Committed r209540: <http://trac.webkit.org/changeset/209540>
All reviewed patches have been landed. Closing bug.