Bug 165524 - [Win] Some versions of Cygwin Perl generate incorrect C++ code.
Summary: [Win] Some versions of Cygwin Perl generate incorrect C++ code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-07 04:16 PST by Per Arne Vollan
Modified: 2016-12-08 01:05 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.15 KB, patch)
2016-12-07 04:47 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-12-07 04:16:09 PST
Perl strings with variables seems to be handled differently, depending on which version of Cygwin Perl you are running.

For example, when Cygwin Perl v5.14.2 is processing the string "$domJITClassName::$domJITClassName()\n", it will emit a warning saying the variable '$domJITClassName::' is being used uninitialized.

This will generate invalid C++ code.
Comment 1 Per Arne Vollan 2016-12-07 04:18:49 PST
<rdar://problem/29508043>
Comment 2 Per Arne Vollan 2016-12-07 04:47:07 PST
Created attachment 296388 [details]
Patch
Comment 3 Daniel Bates 2016-12-07 14:57:29 PST
Comment on attachment 296388 [details]
Patch

r=me
Comment 4 Per Arne Vollan 2016-12-08 00:38:24 PST
(In reply to comment #3)
> Comment on attachment 296388 [details]
> Patch
> 
> r=me

Thanks for reviewing :)
Comment 5 WebKit Commit Bot 2016-12-08 01:04:57 PST
Comment on attachment 296388 [details]
Patch

Clearing flags on attachment: 296388

Committed r209532: <http://trac.webkit.org/changeset/209532>
Comment 6 WebKit Commit Bot 2016-12-08 01:05:02 PST
All reviewed patches have been landed.  Closing bug.