Bug 165503 - performance.now() should truncate to 100us
Summary: performance.now() should truncate to 100us
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-06 17:04 PST by Geoffrey Garen
Modified: 2018-01-05 11:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.13 KB, patch)
2016-12-06 17:05 PST, Geoffrey Garen 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-12-06 17:04:51 PST 
performance.now() should truncate to 100us
Comment 1 Geoffrey Garen 2016-12-06 17:05:31 PST 
Created attachment 296354 [details]
Patch
Comment 2 Mark Lam 2016-12-06 17:13:02 PST 
Comment on attachment 296354 [details]
Patch

r=me.
Comment 3 Geoffrey Garen 2016-12-07 10:40:11 PST 
Committed r209462: <http://trac.webkit.org/changeset/209462>
Comment 4 Chris Dumez 2016-12-08 12:05:04 PST 
Comment on attachment 296354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296354&action=review

> Source/WebCore/page/Performance.cpp:217
> +    const double resolutionSeconds = 0.0001;

Spec says:
A DOMHighResTimeStamp should represent a time in milliseconds accurate to 5 microseconds
Comment 5 Geoffrey Garen 2016-12-08 12:12:25 PST 
Yeah, we disagree with that behavior.
Comment 6 Carlos Alberto Lopez Perez 2018-01-05 11:43:31 PST 
(In reply to Geoffrey Garen from comment #5)
> Yeah, we disagree with that behavior.

I guess then is worth adding a comment explaining that this is done on purpose,  and to let know about it to anyone that feels like fixing this back to follow the spec.