Bug 165496 - REGRESSION(r203912): Web Inspector: Navigation sidebar widths are not saved
Summary: REGRESSION(r203912): Web Inspector: Navigation sidebar widths are not saved
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-06 15:54 PST by Devin Rousso
Modified: 2016-12-07 20:27 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.45 KB, patch)
2016-12-06 15:57 PST, Devin Rousso 		mattbaker: review+
Details | Formatted Diff | Diff
Patch (7.40 KB, patch)
2016-12-07 17:24 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-12-06 15:54:35 PST 
Moving the width-saving WI.Setting logic to the WI.TabBrowser caused the navigation sidebar to no longer remember its width.
Comment 1 Devin Rousso 2016-12-06 15:57:37 PST 
Created attachment 296341 [details]
Patch
Comment 2 Matt Baker 2016-12-07 16:25:32 PST 
Comment on attachment 296341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296341&action=review

Looks good! r=me with nits

> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:299
> +    _sidebarWidthDidChange(event) {

Open brace should be on its own line.

> Source/WebInspectorUI/UserInterface/Views/TabContentView.js:51
> +        this._navigationSidebarWidthSetting = new WebInspector.Setting(identifier + "-navigation-sidebar-width", 300);

Since 300 is used in two places lets make it a const:

const defaultSidebarWidth = 300;
Comment 3 Devin Rousso 2016-12-07 17:24:32 PST 
Created attachment 296448 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-07 20:27:47 PST 
Comment on attachment 296448 [details]
Patch

Clearing flags on attachment: 296448

Committed r209519: <http://trac.webkit.org/changeset/209519>
Comment 5 WebKit Commit Bot 2016-12-07 20:27:51 PST 
All reviewed patches have been landed.  Closing bug.