Bug 165494 - [Modern Media Controls] Media controls use the fullscreen layout after going from inline to fullscreen to PiP to inline
Summary: [Modern Media Controls] Media controls use the fullscreen layout after going ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-06 15:11 PST by Antoine Quint
Modified: 2016-12-06 15:49 PST (History)
0 users

See Also:

Attachments
Patch (11.25 KB, patch)
2016-12-06 15:17 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-12-06 15:11:37 PST 
[Modern Media Controls] Media controls use the fullscreen layout after going from inline to fullscreen to PiP to inline
Comment 1 Antoine Quint 2016-12-06 15:17:18 PST 
Created attachment 296332 [details]
Patch
Comment 2 Dean Jackson 2016-12-06 15:19:59 PST 
Comment on attachment 296332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296332&action=review

> Source/WebCore/ChangeLog:8
> +        We would only call _updateControlsIfNeeded() when entering or leaving fullscreen, so we going from fullscreen to PiP to

Grammar: so we going
Comment 3 Antoine Quint 2016-12-06 15:49:23 PST 
https://trac.webkit.org/changeset/209432