Bug 165493 – PureNaN: fix typo

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[JF Bastien]

I doubt IEEE 854 was the intent.

[JF Bastien]

Created attachment 296326 [details]
patch

[Mark Lam]

Comment on attachment 296326 [details]
patch

r=me

[WebKit Commit Bot]

Attachment 296326 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/PureNaN.h:35:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 296326 [details]
patch

Clearing flags on attachment: 296326

Committed r209429: <http://trac.webkit.org/changeset/209429>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

Can't believe you fixed the typo and not the two spaces after periods in the comment.

[JF Bastien]

(In reply to comment #6)
> Can't believe you fixed the typo and not the two spaces after periods in the
> comment.

That's the style throughout the file. I assume that was intentional on Fil's part, but IEEE-854 is actively misleading because it *almost* means something (it's an abandoned standard which IEEE-754 replaced).

[Filip Pizlo]

(In reply to comment #7)
> (In reply to comment #6)
> > Can't believe you fixed the typo and not the two spaces after periods in the
> > comment.
> 
> That's the style throughout the file. I assume that was intentional on Fil's
> part, but IEEE-854 is actively misleading because it *almost* means
> something (it's an abandoned standard which IEEE-754 replaced).

I know I'm not supposed to use two spaces but I'm a terrible person.