Bug 165487 - Correct SDKROOT values in xcconfig files
Summary: Correct SDKROOT values in xcconfig files
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2016-12-06 13:36 PST by Alexey Proskuryakov
Modified: 2016-12-06 16:35 PST (History)
9 users (show)

See Also:

proposed patch (18.08 KB, patch)
2016-12-06 13:49 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2016-12-06 13:36:42 PST
Comment 1 Alexey Proskuryakov 2016-12-06 13:49:28 PST
Created attachment 296314 [details]
proposed patch

There were a couple projects in Tools that had different code from everything else. As far as I can tell, that wasn't intentional. One of them got overlooked when converting to SDK selectors, and another is a new one that copied the configs.
Comment 2 WebKit Commit Bot 2016-12-06 13:52:06 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 mitz 2016-12-06 13:53:30 PST
Please make sure that this doesn’t cause any problems when working with the projects in the Xcode IDE, i.e. that it’s still possible to select Simulator destinations and build for the Simulator.
Comment 4 Alexey Proskuryakov 2016-12-06 14:02:43 PST
I could select a simulator destination, and the build started successfully (built bmalloc and WTF).

It wasn't doing an incremental build after my command line one, but that never works for me.
Comment 5 WebKit Commit Bot 2016-12-06 16:35:17 PST
Comment on attachment 296314 [details]
proposed patch

Clearing flags on attachment: 296314

Committed r209434: <http://trac.webkit.org/changeset/209434>
Comment 6 WebKit Commit Bot 2016-12-06 16:35:23 PST
All reviewed patches have been landed.  Closing bug.