RESOLVED FIXED 165484
Add a new MachMessage class and use it for sending outgoing messages 
https://bugs.webkit.org/show_bug.cgi?id=165484
Summary Add a new MachMessage class and use it for sending outgoing messages
Anders Carlsson
Reported 2016-12-06 12:38:08 PST
Add a new MachMessage class and use it for sending outgoing messages
Attachments
Patch (13.98 KB, patch)
2016-12-06 12:41 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-12-06 12:41:17 PST
Created attachment 296308 [details] Patch
Sam Weinig
Comment 2 2016-12-06 13:44:46 PST
Comment on attachment 296308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296308&action=review > Source/WebKit2/Platform/IPC/mac/MachMessage.cpp:36 > + return std::unique_ptr<MachMessage> { new (NotNull, memory) MachMessage { length } }; > + > +} Extra newline. > Source/WebKit2/Platform/IPC/mac/MachMessage.h:36 > +public: > + > + static std::unique_ptr<MachMessage> create(size_t length); Extra newline.
Anders Carlsson
Comment 3 2016-12-06 14:00:18 PST
Committed r209418: <http://trac.webkit.org/changeset/209418>
Csaba Osztrogonác
Comment 4 2016-12-07 03:31:10 PST
(In reply to comment #3) > Committed r209418: <http://trac.webkit.org/changeset/209418> It broke the Apple Mac cmake build: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/10484
Alex Christensen
Comment 5 2016-12-07 12:26:00 PST
http://trac.webkit.org/changeset/209467
Note You need to log in before you can comment on or make changes to this bug.